net/net.gyp - Issue 18792002: WebSocketBasicStream framing logic

Unified Diff: net/net.gyp

Issue 18792002: WebSocketBasicStream framing logic (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add includes and rename "data" variable Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/net.gyp

diff --git a/net/net.gyp b/net/net.gyp

index 445bf3d7196f8347e595f7886f90472442b72b11..6e5fa4ef3df9cf6cde759d4833f156b904daf073 100644

--- a/net/net.gyp

+++ b/net/net.gyp

@@ -1085,6 +1085,8 @@

'url_request/url_request_throttler_manager.h',

'url_request/view_cache_helper.cc',

'url_request/view_cache_helper.h',

+ 'websockets/websocket_basic_stream.cc',

+ 'websockets/websocket_basic_stream.h',

'websockets/websocket_channel.cc',

'websockets/websocket_channel.h',

'websockets/websocket_errors.cc',

@@ -1853,6 +1855,7 @@

'url_request/url_request_throttler_unittest.cc',

'url_request/url_request_unittest.cc',

'url_request/view_cache_helper_unittest.cc',

+ 'websockets/websocket_basic_stream_test.cc',

szym 2013/08/27 22:54:04 The file name should end with _unittest.cc If pos

Adam Rice 2013/08/28 12:01:11 *_unittest.cc is deprecated: http://google-stylegu

szym 2013/08/28 21:17:54 I suggest using _unittest.cc for consistency. The

Adam Rice 2013/08/29 13:03:23 I discussed it with the team, and we decided to do

'websockets/websocket_channel_test.cc',

'websockets/websocket_errors_unittest.cc',

'websockets/websocket_frame_parser_unittest.cc',

« no previous file with comments | « no previous file | net/websockets/README » ('j') | net/websockets/websocket_basic_stream.h » ('J')