Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1879193005: Revert of Move profile handling code to a child class of SharedPageState (Closed)

Created:
4 years, 8 months ago by rnephew (Reviews Here)
Modified:
4 years, 8 months ago
Reviewers:
eakuefner, gurrrik
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move profile handling code to a child class of SharedPageState (patchset #2 id:20001 of https://codereview.chromium.org/1884493002/ ) Reason for revert: Breaks startup tests. crbug.com/603121 Original issue's description: > Move profile handling code to a child class of SharedPageState > > There will be a separate review for removing this logic from SharedPageState. > More info: https://codereview.chromium.org/1871033002/ > > BUG= > > Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4 > Cr-Commit-Position: refs/heads/master@{#386943} TBR=eakuefner@chromium.org,gurrrik@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/885a2d6ffa9903ce841fb69f8f917265a32b5749 Cr-Commit-Position: refs/heads/master@{#387074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -161 lines) Patch
M tools/perf/page_sets/pregenerated_large_profile_shared_state.py View 1 chunk +5 lines, -4 lines 0 comments Download
D tools/perf/page_sets/pregenerated_profile_shared_state.py View 1 chunk +0 lines, -157 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rnephew (Reviews Here)
Created Revert of Move profile handling code to a child class of SharedPageState
4 years, 8 months ago (2016-04-13 20:17:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879193005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879193005/1
4 years, 8 months ago (2016-04-13 20:18:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 20:18:46 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 20:20:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/885a2d6ffa9903ce841fb69f8f917265a32b5749
Cr-Commit-Position: refs/heads/master@{#387074}

Powered by Google App Engine
This is Rietveld 408576698