annotated_run: extract robust_tempdir so it can be shared with kitchen_run

annotated_run: extract robust_tempdir so it can be shared with kitchen_run

This will be needed for https://codereview.chromium.org/1869053002

BUG=chromium:593999
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299881

[Paweł Hajdan Jr., 2016-04-13 08:40:58]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 08:41:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879173003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879173003/1

[commit-bot: I haz the power, 2016-04-13 08:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 08:48:32]

Dry run: Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Paweł Hajdan Jr., 2016-04-13 08:54:09]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 08:54:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879173003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879173003/20001

[commit-bot: I haz the power, 2016-04-13 08:58:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 08:58:02]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2016-04-13 09:12:30]

kjellander@chromium.org changed reviewers:
+ kjellander@chromium.org

[kjellander_chromium, 2016-04-13 09:12:31]

Looks good, but with robust_tempdir as its own module, this seems to be a good
opportunity to add a unit test for it that at least ensures everything is
cleaned up, since leaking files could potentially be a serious issue.

[Paweł Hajdan Jr., 2016-04-13 09:29:50]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 09:29:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879173003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879173003/40001

[commit-bot: I haz the power, 2016-04-13 09:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 09:37:48]

Dry run: Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Paweł Hajdan Jr., 2016-04-13 09:40:07]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 09:40:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879173003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879173003/60001

[commit-bot: I haz the power, 2016-04-13 09:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 09:44:26]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-04-13 09:50:11]

Good point, added a simple test. PTAL.

[kjellander_chromium, 2016-04-13 09:57:44]

lgtm with two optional comments.

https://codereview.chromium.org/1879173003/diff/60001/scripts/slave/robust_te...
File scripts/slave/robust_tempdir.py (right):

https://codereview.chromium.org/1879173003/diff/60001/scripts/slave/robust_te...
scripts/slave/robust_tempdir.py:33: def __init__(self, prefix, leak=False):
Can you document the parameters? It's not obvious what leak actually does.

Maybe even name it something like 'no_cleanup' instead?

https://codereview.chromium.org/1879173003/diff/60001/scripts/slave/robust_te...
scripts/slave/robust_tempdir.py:71: if self._leak:
This refers to the --leak flag to annotated_run.py, which doesn't really make
sense anymore. I suggest just remove that part.

[Paweł Hajdan Jr., 2016-04-13 10:12:33]

Thanks. Both comments applied.

[Paweł Hajdan Jr., 2016-04-13 10:12:35]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-04-13 10:12:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@chromium.org
Link to the patchset: https://codereview.chromium.org/1879173003/#ps80001
(title: "review")

[commit-bot: I haz the power, 2016-04-13 10:12:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879173003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879173003/80001

[commit-bot: I haz the power, 2016-04-13 10:16:39]

Description was changed from

==========
annotated_run: extract robust_tempdir so it can be shared with kitchen_run

This will be needed for https://codereview.chromium.org/1869053002

BUG=chromium:593999
==========

to

==========
annotated_run: extract robust_tempdir so it can be shared with kitchen_run

This will be needed for https://codereview.chromium.org/1869053002

BUG=chromium:593999

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299881
==========

[commit-bot: I haz the power, 2016-04-13 10:16:40]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299881