Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1879143004: Fix audio glitch issue introduced by security fix for format changes. (Closed)

Created:
4 years, 8 months ago by DaleCurtis
Modified:
4 years, 8 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix audio glitch issue introduced by security fix for format changes. The patch was comparing the new sample rate value versus itself instead of the old sample rate value versus the new. BUG=602731 TEST=no more stuttering. Committed: https://crrev.com/f4e5abab8d5d01bbb920bac53b0c9598412e4105 Cr-Commit-Position: refs/heads/master@{#386887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M media/filters/ffmpeg_audio_decoder.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
DaleCurtis
4 years, 8 months ago (2016-04-12 22:54:29 UTC) #2
wolenetz
lgtm - it'd be nice to have an automated test though. For making into M50 ...
4 years, 8 months ago (2016-04-12 23:01:57 UTC) #4
DaleCurtis
Agreed, the tests chcunningham@ added should have caught this but they aren't actually working. Punting ...
4 years, 8 months ago (2016-04-12 23:02:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879143004/1
4 years, 8 months ago (2016-04-12 23:02:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 01:36:13 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 01:38:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e5abab8d5d01bbb920bac53b0c9598412e4105
Cr-Commit-Position: refs/heads/master@{#386887}

Powered by Google App Engine
This is Rietveld 408576698