Allow fallbackFactory to be null in RecordingImageBufferSurface.

Allow fallbackFactory to be null in RecordingImageBufferSurface.

This will mean that as long as the user doesn't call any "bad" methods
(writePixels etc) and is only used for one frame calling getPicture will
always result in a non-null SkPicture.

BUG=578252
Committed: https://crrev.com/13754fa546f6c83d4ded6b2a7d9fb37f09da48de
Cr-Commit-Position: refs/heads/master@{#388026}

[ikilpatrick, 2016-04-12 20:58:20]

ikilpatrick@chromium.org changed reviewers:
+ junov@chromium.org

[ikilpatrick, 2016-04-12 20:58:21]

This is intentionally simple :)

(perhaps too simple? feels a bit unsafe)

[Justin Novosad, 2016-04-18 19:30:27]

On 2016/04/12 20:58:21, ikilpatrick wrote:
> This is intentionally simple :)
> 
> (perhaps too simple? feels a bit unsafe)

What are you saying? Simple is awesome.
I find your lack of faith disturbing. ;-)

lgtm

[ikilpatrick, 2016-04-18 19:39:14]

On 2016/04/18 19:30:27, Justin Novosad wrote:
> On 2016/04/12 20:58:21, ikilpatrick wrote:
> > This is intentionally simple :)
> > 
> > (perhaps too simple? feels a bit unsafe)
> 
> What are you saying? Simple is awesome.
> I find your lack of faith disturbing. ;-)
> 
> lgtm

Recovering google engineer. :)

[ikilpatrick, 2016-04-18 19:56:38]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-04-18 19:56:38]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1879133004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-18 19:56:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879133004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879133004/40001

[commit-bot: I haz the power, 2016-04-18 21:14:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-18 21:16:50]

Description was changed from

==========
Allow fallbackFactory to be null in RecordingImageBufferSurface.

This will mean that as long as the user doesn't call any "bad" methods
(writePixels etc) and is only used for one frame calling getPicture will
always result in a non-null SkPicture.

BUG=578252
==========

to

==========
Allow fallbackFactory to be null in RecordingImageBufferSurface.

This will mean that as long as the user doesn't call any "bad" methods
(writePixels etc) and is only used for one frame calling getPicture will
always result in a non-null SkPicture.

BUG=578252

Committed: https://crrev.com/13754fa546f6c83d4ded6b2a7d9fb37f09da48de
Cr-Commit-Position: refs/heads/master@{#388026}
==========

[commit-bot: I haz the power, 2016-04-18 21:16:52]

Patchset 3 (id:??) landed as
https://crrev.com/13754fa546f6c83d4ded6b2a7d9fb37f09da48de
Cr-Commit-Position: refs/heads/master@{#388026}