Support the Aec dump for the APM in chrome

content/renderer/media/media_stream_audio_processor.h

Index: content/renderer/media/media_stream_audio_processor.h
diff --git a/content/renderer/media/media_stream_audio_processor.h b/content/renderer/media/media_stream_audio_processor.h
index 6b4cf8fe104ba928fb7781fdb8028e89ff99ee3a..73d87b5703d8dd5f0ac7f8e41f5cf16cdbfb8761 100644
--- a/content/renderer/media/media_stream_audio_processor.h
+++ b/content/renderer/media/media_stream_audio_processor.h
@@ -6,6 +6,7 @@
 #define CONTENT_RENDERER_MEDIA_MEDIA_STREAM_AUDIO_PROCESSOR_H_
 
 #include "base/atomicops.h"
+#include "base/platform_file.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_checker.h"
 #include "base/time/time.h"
@@ -45,11 +46,14 @@ class CONTENT_EXPORT MediaStreamAudioProcessor :
   // |playout_data_source| is used to register this class as a sink to the
   // WebRtc playout data for processing AEC. If clients do not enable AEC,
   // |playout_data_source| won't be used.
-  MediaStreamAudioProcessor(const media::AudioParameters& source_params,
-                            const blink::WebMediaConstraints& constraints,
+  MediaStreamAudioProcessor(const blink::WebMediaConstraints& constraints,
                             int effects,
                             WebRtcPlayoutDataSource* playout_data_source);
 
+  // Called when format of the capture data has changed.
+  // Called on the main render thread.  The caller is responsible fo

[Henrik Grunell, 2014/03/07 09:14:57]

Ooo, now I'm curious! :) Responsible for what? World economy? Sorting candy into
the right boxes? (Comment is chopped.)

Maybe add a comment that the capture thread will change?

[no longer working on chromium, 2014/03/07 10:14:54]

Done.

+  void OnCaptureFormatChanged(const media::AudioParameters& source_params);

[Henrik Grunell, 2014/03/06 19:55:12]

Why is this needed in this CL?

[no longer working on chromium, 2014/03/06 20:00:36]

It is needed in order not to create a new processor when the format has changed.
Previously, we create a new instance of MediaStreamAudioProcessor when the
capture format has changed, but this will be a problem for AEC dump since we can
only start AEC dump on on processor.

+
   // Pushes capture data in |audio_source| to the internal FIFO.
   // Called on the capture audio thread.
   void PushCaptureData(media::AudioBus* audio_source);
@@ -73,7 +77,6 @@ class CONTENT_EXPORT MediaStreamAudioProcessor :
                              int* new_volume,
                              int16** out);
 
-
   // The audio format of the input to the processor.
   const media::AudioParameters& InputFormat() const;
 
@@ -83,6 +86,12 @@ class CONTENT_EXPORT MediaStreamAudioProcessor :
   // Accessor to check if the audio processing is enabled or not.
   bool has_audio_processing() const { return audio_processing_ != NULL; }
 
+  // Starts/Stops the Aec dump on the |audio_processing_|.
+  // Called on the main render thread.
+  // This method takes the ownership of |aec_dump_file|.
+  void StartAecDump(const base::PlatformFile& aec_dump_file);
+  void StopAecDump();
+
  protected:
   friend class base::RefCountedThreadSafe<MediaStreamAudioProcessor>;
   virtual ~MediaStreamAudioProcessor();