Support the Aec dump for the APM in chrome

content/renderer/media/webrtc_audio_device_impl.h

Index: content/renderer/media/webrtc_audio_device_impl.h
diff --git a/content/renderer/media/webrtc_audio_device_impl.h b/content/renderer/media/webrtc_audio_device_impl.h
index 7354002dcaa6c79129ecf24e5517b2917bc9e14a..0e96966149b44a7b95091f4361092349f2ec45c7 100644
--- a/content/renderer/media/webrtc_audio_device_impl.h
+++ b/content/renderer/media/webrtc_audio_device_impl.h
@@ -18,6 +18,7 @@
 #include "content/renderer/media/webrtc_audio_capturer.h"
 #include "content/renderer/media/webrtc_audio_device_not_impl.h"
 #include "content/renderer/media/webrtc_audio_renderer.h"
+#include "ipc/ipc_platform_file.h"
 #include "media/base/audio_capturer_source.h"
 #include "media/base/audio_renderer_sink.h"
 
@@ -345,6 +346,14 @@ class CONTENT_EXPORT WebRtcAudioDeviceImpl
     return renderer_;
   }
 
+  // Enables the Aec dump.  When this method is called, Aec dump will be
+  // started on the default capturer.

[Henrik Grunell, 2014/03/06 10:12:20]

Comment that it takes ownership of |file_handle|.

Comment that if there's no capturer yet, it holds on to the file until one is
created and then enabled the dump.

[no longer working on chromium, 2014/03/06 18:57:21]

Done.

+  void EnableAecDump(IPC::PlatformFileForTransit file_handle);
+
+  // Disables the Aec dump.  When this method is called, the ongoing Aec dump
+  // will be stopped, and no Aec dump will be started.
+  void DisableAecDump();
+
  private:
   typedef std::list<scoped_refptr<WebRtcAudioCapturer> > CapturerList;
   typedef std::list<WebRtcPlayoutDataSource::Sink*> PlayoutDataSinkList;
@@ -383,6 +392,13 @@ class CONTENT_EXPORT WebRtcAudioDeviceImpl
   virtual void AddPlayoutSink(WebRtcPlayoutDataSource::Sink* sink) OVERRIDE;
   virtual void RemovePlayoutSink(WebRtcPlayoutDataSource::Sink* sink) OVERRIDE;
 
+  // This method will stop the Aec dump on all the non-default capturer and
+  // start the Aec dump on the default capturer.
+  void StartAecDump();

[Henrik Grunell, 2014/03/06 10:12:20]

Stick with either Enable/Disable or Start/Stop naming throughout all classes.

[no longer working on chromium, 2014/03/06 18:57:21]

I suggest not. It is better to put all the code together in one method instead
of spreading the use cases around.
By using this method, we know exactly what will happen after calling
StartAecDump(). Hope it is fine to keep it.

[Henrik Grunell, 2014/03/06 19:55:12]

I just meant the naming of the functions. Either StartAecDump everywhere or
EnableAecDump everywhere. Same with Stop or Disable.

+
+  // This method will stop the Aec dump on the default capturer.
+  void StopAecDump();
+
   // Used to DCHECK that we are called on the correct thread.
   base::ThreadChecker thread_checker_;
 
@@ -431,6 +447,9 @@ class CONTENT_EXPORT WebRtcAudioDeviceImpl
   // It is only accessed by the audio render thread.
   std::vector<int16> render_buffer_;
 
+  // Used for start the Aec dump on the default capturer.
+  base::PlatformFile aec_dump_file_;
+
   DISALLOW_COPY_AND_ASSIGN(WebRtcAudioDeviceImpl);
 };