Support the Aec dump for the APM in chrome

content/renderer/media/media_stream_audio_processor_options.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_audio_processor_options.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 126 matching lines @@
   // Configure the update period to 100ms (10 * 10ms) in the typing detector.
   typing_detector->SetParameters(0, 0, 0, 0, 0, 10);
 }
 
 void EnableExperimentalEchoCancellation(AudioProcessing* audio_processing) {
   webrtc::Config config;
   config.Set<webrtc::DelayCorrection>(new webrtc::DelayCorrection(true));
   audio_processing->SetExtraOptions(config);
 }
 
-void StartAecDump(AudioProcessing* audio_processing) {
-  // TODO(grunell): Figure out a more suitable directory for the audio dump
-  // data.
-  base::FilePath path;
-#if defined(CHROMEOS)
-  PathService::Get(base::DIR_TEMP, &path);
-#elif defined(ANDROID)
-  path = base::FilePath(FILE_PATH_LITERAL("sdcard"));
-#else
-  PathService::Get(base::DIR_EXE, &path);
-#endif
-  base::FilePath file = path.Append(FILE_PATH_LITERAL("audio.aecdump"));
+void StartEchoCancellationDump(AudioProcessing* audio_processing,
+                               const base::PlatformFile& aec_dump_file) {
+  DCHECK_NE(aec_dump_file, base::kInvalidPlatformFileValue);
 
-#if defined(OS_WIN)
-  const std::string file_name = base::WideToUTF8(file.value());
-#else
-  const std::string file_name = file.value();
-#endif
-  if (audio_processing->StartDebugRecording(file_name.c_str()))
+  FILE* handle = base::FdopenPlatformFile(aec_dump_file, "w");

[Henrik Grunell, 2014/03/06 10:12:20]

Change "handle" -> "file_stream" or "stream".

[no longer working on chromium, 2014/03/06 18:57:21]

Done.

+  if (!handle) {
+    LOG(ERROR) << "Failed to open AEC dump file";
+    return;
+  }
+
+  if (audio_processing->StartDebugRecording(handle))
     DLOG(ERROR) << "Fail to start AEC debug recording";
 }
 
-void StopAecDump(AudioProcessing* audio_processing) {
+void StopEchoCancellationDump(AudioProcessing* audio_processing) {
   if (audio_processing->StopDebugRecording())
     DLOG(ERROR) << "Fail to stop AEC debug recording";
 }
 
 void EnableAutomaticGainControl(AudioProcessing* audio_processing) {
 #if defined(OS_ANDROID) || defined(OS_IOS)
   const webrtc::GainControl::Mode mode = webrtc::GainControl::kFixedDigital;
 #else
   const webrtc::GainControl::Mode mode = webrtc::GainControl::kAdaptiveAnalog;
 #endif
   int err = audio_processing->gain_control()->set_mode(mode);
   err |= audio_processing->gain_control()->Enable(true);
   CHECK_EQ(err, 0);
 }
 
 }  // namespace content