Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1879103002: Convert main-thread overscroll parameters into viewport space. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Majid's review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 DCHECK(frame->document()); 346 DCHECK(frame->document());
347 Fullscreen::fullyExitFullscreen(*frame->document()); 347 Fullscreen::fullyExitFullscreen(*frame->document());
348 348
349 WebViewImpl* newView = toWebViewImpl( 349 WebViewImpl* newView = toWebViewImpl(
350 m_webView->client()->createView(WebLocalFrameImpl::fromFrame(frame), Wra ppedResourceRequest(r.resourceRequest()), features, r.frameName(), policy, shoul dSetOpener == NeverSetOpener)); 350 m_webView->client()->createView(WebLocalFrameImpl::fromFrame(frame), Wra ppedResourceRequest(r.resourceRequest()), features, r.frameName(), policy, shoul dSetOpener == NeverSetOpener));
351 if (!newView) 351 if (!newView)
352 return nullptr; 352 return nullptr;
353 return newView->page(); 353 return newView->page();
354 } 354 }
355 355
356 void ChromeClientImpl::didOverscroll(const FloatSize& unusedDelta, const FloatSi ze& accumulatedRootOverScroll, const FloatPoint& position, const FloatSize& velo city) 356 void ChromeClientImpl::didOverscroll(const FloatSize& overscrollDelta, const Flo atSize& accumulatedOverscroll, const FloatPoint& positionInViewport, const Float Size& velocityInViewport)
357 { 357 {
358 if (!m_webView->client()) 358 if (!m_webView->client())
359 return; 359 return;
360 360
361 m_webView->client()->didOverscroll(unusedDelta, accumulatedRootOverScroll, p osition, velocity); 361 m_webView->client()->didOverscroll(overscrollDelta, accumulatedOverscroll, p ositionInViewport, velocityInViewport);
362 } 362 }
363 363
364 void ChromeClientImpl::show(NavigationPolicy navigationPolicy) 364 void ChromeClientImpl::show(NavigationPolicy navigationPolicy)
365 { 365 {
366 if (m_webView->client()) 366 if (m_webView->client())
367 m_webView->client()->show(effectiveNavigationPolicy(navigationPolicy, m_ windowFeatures)); 367 m_webView->client()->show(effectiveNavigationPolicy(navigationPolicy, m_ windowFeatures));
368 } 368 }
369 369
370 void ChromeClientImpl::setToolbarsVisible(bool value) 370 void ChromeClientImpl::setToolbarsVisible(bool value)
371 { 371 {
(...skipping 717 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 if (m_webView->pageImportanceSignals()) 1089 if (m_webView->pageImportanceSignals())
1090 m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript(); 1090 m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript();
1091 } 1091 }
1092 1092
1093 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler(BlameContex t* blameContext) 1093 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler(BlameContex t* blameContext)
1094 { 1094 {
1095 return adoptPtr(m_webView->scheduler()->createFrameScheduler(blameContext).r elease()); 1095 return adoptPtr(m_webView->scheduler()->createFrameScheduler(blameContext).r elease());
1096 } 1096 }
1097 1097
1098 } // namespace blink 1098 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698