Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1879093002: Revert "Fix handling of cross-origin windows in dartium and better align general handling of differ… (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects." This reverts commit f382890e1a1a719ad6d6545cb50dc0b01cf2e00c. Reverting while tests are fixed. BUG= Committed: https://github.com/dart-lang/sdk/commit/688eeb555c9e2b93e38a18a02c78aee85b9d9665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -150 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 21 chunks +44 lines, -78 lines 0 comments Download
M sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +3 lines, -9 lines 0 comments Download
M tools/dom/scripts/generate_blink_file.py View 1 chunk +33 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 3 chunks +23 lines, -28 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 2 chunks +5 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Jacob
Committed patchset #1 (id:1) manually as 688eeb555c9e2b93e38a18a02c78aee85b9d9665.
4 years, 8 months ago (2016-04-12 18:28:10 UTC) #2
Jacob
4 years, 8 months ago (2016-04-12 18:28:11 UTC) #4
Message was sent while issue was closed. 
TBR

Powered by Google App Engine
This is Rietveld 408576698