Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1879083002: Fix Windows 32-bit GN build. (Closed)

Created:
4 years, 8 months ago by Oliver Chang
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/fxge/ge/fx_ge_fontmap.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/include/fx_font.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Oliver Chang
ptal. See https://bugs.chromium.org/p/pdfium/issues/detail?id=475 or why these breakages keep happening (and don't get caught by our ...
4 years, 8 months ago (2016-04-12 18:17:56 UTC) #1
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-12 18:38:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879083002/1
4 years, 8 months ago (2016-04-12 18:39:12 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 18:53:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6b19ec629d32e872d2e430987526162b2954...

Powered by Google App Engine
This is Rietveld 408576698