Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1879053003: Replace DefineIndexedProperty with %CreateDataProperty (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace DefineIndexedProperty with %CreateDataProperty This should bring back the performance of speedometer-backbone at least very close to the performance before @@species. BUG=chromium:596825 LOG=n Committed: https://crrev.com/a915f5bf48658a8114cd57c81133d08b21bc251c Cr-Commit-Position: refs/heads/master@{#35468}

Patch Set 1 #

Patch Set 2 : Get rid of AddIndexedProperty altogether #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -55 lines) Patch
M src/js/array.js View 1 12 chunks +8 lines, -32 lines 0 comments Download
M src/js/regexp.js View 1 6 chunks +4 lines, -6 lines 0 comments Download
M src/js/runtime.js View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/js/typedarray.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-13 09:36:41 UTC) #3
Dan Ehrenberg
lgtm
4 years, 8 months ago (2016-04-13 16:05:42 UTC) #5
Jakob Kummerow
lgtm
4 years, 8 months ago (2016-04-13 16:34:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879053003/20001
4 years, 8 months ago (2016-04-13 18:23:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/84) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-13 18:41:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879053003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879053003/40001
4 years, 8 months ago (2016-04-14 07:12:29 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-14 07:39:35 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 07:40:10 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a915f5bf48658a8114cd57c81133d08b21bc251c
Cr-Commit-Position: refs/heads/master@{#35468}

Powered by Google App Engine
This is Rietveld 408576698