Issue 187903007: Make kAllowedToAccessOnNonjoinableThread debug-only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187903007: Make kAllowedToAccessOnNonjoinableThread debug-only. (Closed)

Created:
6 years, 9 months ago by Nico

Modified:
6 years, 9 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make kAllowedToAccessOnNonjoinableThread debug-only. This is only used in !NDEBUG builds, and making the variable only available there makes it harder to break -Wunused-const-variable builds with custom traits. Follow-up to r255159. BUG=349521, 307668 R=fischman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255194

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
M	base/android/build_info.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/lazy_instance.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	base/memory/singleton.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Ami GONE FROM CHROMIUM

Also do https://code.google.com/p/chromium/codesearch#chromium/src/base/android/build_info.cc&l=40 ? LGTM

6 years, 9 months ago (2014-03-06 00:02:07 UTC) #2

Nico

done, thanks On Wed, Mar 5, 2014 at 4:02 PM, <fischman@chromium.org> wrote: > Also do ...

6 years, 9 months ago (2014-03-06 00:05:47 UTC) #3

vivekg

6 years, 9 months ago (2014-03-06 01:18:36 UTC) #6

Message was sent while issue was closed.

On 2014/03/06 01:12:05, Nico wrote:
> Committed patchset #2 manually as r255194.

Thank you for the followup :)