Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 187903004: Revert of Move testRunner.startSpeechInput/setValueForUser to internals (Closed)

Created:
6 years, 9 months ago by Peter Beverloo
Modified:
6 years, 9 months ago
Reviewers:
haraken, hajimehoshi
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Revert of Move testRunner.startSpeechInput/setValueForUser to internals (https://codereview.chromium.org/176953009/) Reason for revert: Broke the Android compile: http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/25493/steps/compile/logs/stdio Android does not enable speech input, and the methods called are guarded behind the ENABLE_INPUT_SPEECH compile-time flag. The testing code in Internals.cpp should also be guarded with the same flag. Original issue's description: > Move testRunner.startSpeechInput/setValueForUser to internals > > Now TestRunner is being moved from CppBoundClass to gin::Wrappable, > where it is not appropriate to use WebElements directly. This CL moves > some functions which treats WebElement* from testRunner to internals. > (To be exact, this CL only copies some functions, but I'll remove those ones > in testRunner later.) > > BUG=331301 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168495 TBR=haraken@chromium.org,hajimehoshi@chromium.org NOTREECHECKS=true NOTRY=true BUG=331301 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M LayoutTests/fast/forms/onchange-setvalueforuser.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/speech/input-text-speechstart.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Beverloo
Created Revert of Move testRunner.startSpeechInput/setValueForUser to internals
6 years, 9 months ago (2014-03-05 17:40:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/187903004/1
6 years, 9 months ago (2014-03-05 17:41:28 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 17:42:55 UTC) #3
Message was sent while issue was closed.
Change committed as 168498

Powered by Google App Engine
This is Rietveld 408576698