Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6944)

Unified Diff: build/config/mac/rules.gni

Issue 1879003002: [iOS/GN] Convert //ios/third_party/earl_grey to build with GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-ochamcrest
Patch Set: Remove proxy groups Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/rules.gni ('k') | ios/third_party/earl_grey/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index 6ffe613e0b8e9208c6036d104d68453ce078fce3..2bcfbd68361c450ebb27c24881d0510df66d1cb9 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -88,10 +88,10 @@ template("framework_bundle") {
forward_variables_from(invoker, [ "visibility" ])
}
- if (!defined(deps)) {
- deps = []
+ if (!defined(public_deps)) {
+ public_deps = []
}
- deps += [ ":$_shared_library_bundle_data" ]
+ public_deps += [ ":$_shared_library_bundle_data" ]
bundle_root_dir = _framework_root_dir
bundle_resources_dir = "$bundle_root_dir/Resources"
@@ -114,7 +114,7 @@ template("framework_bundle") {
"$_framework_name",
"$_framework_version",
]
- deps = [
+ public_deps = [
":$_framework_target",
]
}
« no previous file with comments | « build/config/ios/rules.gni ('k') | ios/third_party/earl_grey/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698