[reland] Makes MaterialDesignController initialization explicit

Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
TBR=sky@chromium.org, mkwst@chromium.org, kjellander@chromium.org

Committed: https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e
Cr-Commit-Position: refs/heads/master@{#387186}

[varkha, 2016-04-12 13:05:00]

Description was changed from

==========
Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
==========

to

==========
Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
==========

[varkha, 2016-04-12 13:05:10]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 13:05:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878973002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878973002/1

[varkha, 2016-04-12 13:10:14]

Patchset #1 (id:1) has been deleted

[varkha, 2016-04-12 13:10:41]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 13:10:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878973002/40001

[varkha, 2016-04-12 13:17:26]

Description was changed from

==========
Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
==========

to

==========
Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
TBR=sky@chromium.org, mkwst@chromium.org, kjellander@chromium.org
==========

[commit-bot: I haz the power, 2016-04-12 14:18:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 14:18:23]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-04-12 16:02:34]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 16:02:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878973002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878973002/60001

[commit-bot: I haz the power, 2016-04-12 17:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 17:15:41]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-04-13 19:33:10]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 19:33:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878973002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878973002/80001

[commit-bot: I haz the power, 2016-04-13 19:46:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 19:46:02]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[varkha, 2016-04-13 20:21:13]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[varkha, 2016-04-13 20:21:25]

Patchset #4 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-04-13 20:21:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878973002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878973002/100001

[varkha, 2016-04-13 21:06:41]

Patchset #5 (id:120001) has been deleted

[varkha, 2016-04-13 21:07:16]

Patchset #4 (id:100001) has been deleted

[varkha, 2016-04-13 21:14:15]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 21:14:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878973002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878973002/140001

[varkha, 2016-04-13 21:16:54]

varkha@chromium.org changed reviewers:
+ sky@chromium.org

[varkha, 2016-04-13 21:16:55]

sky@, can you please take another look?
I kept patch set #1 as the previous attempt to land (that broke some bots).

Changes from patch set #1:
- Renamed UninitializeMode -> Uninitialize and made it not reset mode to
non-material which was wrong.
- replaced cases where UninitializeMode was used at the end of test cases with
scoped use of MaterialDesignControllerTestAPI to restore state. This corrects
the cases that were failing on valgrind where order of tests was different. The
tests should not be sensitive to order now.
- Corrected NotifierSettingsViewTest to pass on non-CQ bots (original reason for
revert).
- Unrelated rebase that brings unique_ptr<> instead of scoped_ptr<>.

[commit-bot: I haz the power, 2016-04-13 22:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 22:22:36]

Dry run: This issue passed the CQ dry run.

[sky, 2016-04-13 23:49:58]

LGTM

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
File ui/base/test/material_design_controller_test_api.cc (right):

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
ui/base/test/material_design_controller_test_api.cc:7: #include "base/logging.h"
Do you really need this include?

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
File ui/base/test/material_design_controller_test_api.h (right):

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
ui/base/test/material_design_controller_test_api.h:19:
MaterialDesignControllerTestAPI(MaterialDesignController::Mode mode);
explicit.

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
ui/base/test/material_design_controller_test_api.h:26:
MaterialDesignController::Mode previous_mode_;
nit: const on this and the next.

[varkha, 2016-04-14 00:03:33]

Thanks!

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
File ui/base/test/material_design_controller_test_api.cc (right):

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
ui/base/test/material_design_controller_test_api.cc:7: #include "base/logging.h"
On 2016/04/13 23:49:58, sky wrote:
> Do you really need this include?

Obviously not, somehow erasing LOGs wasn't enough.

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
File ui/base/test/material_design_controller_test_api.h (right):

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
ui/base/test/material_design_controller_test_api.h:19:
MaterialDesignControllerTestAPI(MaterialDesignController::Mode mode);
On 2016/04/13 23:49:58, sky wrote:
> explicit.

Done.

https://codereview.chromium.org/1878973002/diff/140001/ui/base/test/material_...
ui/base/test/material_design_controller_test_api.h:26:
MaterialDesignController::Mode previous_mode_;
On 2016/04/13 23:49:58, sky wrote:
> nit: const on this and the next.

Done.

[varkha, 2016-04-14 00:03:59]

The CQ bit was checked by varkha@chromium.org

[varkha, 2016-04-14 00:03:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1878973002/#ps180001
(title: "Made it possible to restore MaterialDesignController state after each
test case (nits)")

[commit-bot: I haz the power, 2016-04-14 00:04:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878973002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878973002/180001

[commit-bot: I haz the power, 2016-04-14 01:13:14]

Description was changed from

==========
Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
TBR=sky@chromium.org, mkwst@chromium.org, kjellander@chromium.org
==========

to

==========
Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
TBR=sky@chromium.org, mkwst@chromium.org, kjellander@chromium.org
==========

[commit-bot: I haz the power, 2016-04-14 01:13:15]

Committed patchset #6 (id:180001)

[commit-bot: I haz the power, 2016-04-14 01:14:15]

Description was changed from

==========
Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
TBR=sky@chromium.org, mkwst@chromium.org, kjellander@chromium.org
==========

to

==========
Fixing NotifierSettingsViewTest.TestLearnMoreButton

Relanding https://codereview.chromium.org/1845343005/.
This CL corrects the test by inheriting NotifierSettingsViewTest from
ViewsTestBase.

BUG=595108
TBR=sky@chromium.org, mkwst@chromium.org, kjellander@chromium.org

Committed: https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e
Cr-Commit-Position: refs/heads/master@{#387186}
==========

[commit-bot: I haz the power, 2016-04-14 01:14:16]

Patchset 6 (id:??) landed as
https://crrev.com/0b40cc39d6a3f5e932374d84d1aba315fcab409e
Cr-Commit-Position: refs/heads/master@{#387186}