fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp - Issue 1878963004: Cleanup CPDFXFA_Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

Issue 1878963004: Cleanup CPDFXFA_Page. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: self review nit Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

diff --git a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

index aa1a1a82c77dbf71d89e4b9c853646c891f4bb43..49ece0f286f16152e4799616e048a5150814e68a 100644

--- a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

+++ b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

@@ -168,7 +168,7 @@ CPDFXFA_Page* CPDFXFA_Document::GetPage(int page_index) {

return pPage;

pPage = new CPDFXFA_Page(this, page_index);

if (!pPage->LoadPage()) {

- delete pPage;

+ pPage->Release();

return nullptr;

}

m_XFAPageList.SetAt(page_index, pPage);

« no previous file with comments | « no previous file | fpdfsdk/fpdfxfa/fpdfxfa_page.cpp » ('j') | fpdfsdk/fpdfxfa/fpdfxfa_page.cpp » ('J')