Cleanup CPDFXFA_Page.

Cleanup CPDFXFA_Page.

- Use std::unique_ptr.
- Make dtor protected.
- Simplify logic.
- Remove unused bits from CXFA_FFPageView as well.

Committed: https://pdfium.googlesource.com/pdfium/+/9f3dbbc54c6981f069b57e6714393ac6c0c64231

[Lei Zhang, 2016-04-12 22:26:40]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-04-12 23:40:00]

lgtm

https://codereview.chromium.org/1878963004/diff/20001/fpdfsdk/fpdfxfa/fpdfxfa...
File fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1878963004/diff/20001/fpdfsdk/fpdfxfa/fpdfxfa...
fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp:162: pPage->AddRef();
nit: pity this isn't called Retain(), then we could use CFX_RetainPtrs to try
and auto-increment these ...

https://codereview.chromium.org/1878963004/diff/20001/fpdfsdk/fpdfxfa/fpdfxfa...
File fpdfsdk/fpdfxfa/fpdfxfa_page.cpp (right):

https://codereview.chromium.org/1878963004/diff/20001/fpdfsdk/fpdfxfa/fpdfxfa...
fpdfsdk/fpdfxfa/fpdfxfa_page.cpp:76: m_pXFAPageView->LoadPageView(nullptr);
nit: I think this (void) was shorthand for // FIXME: check return value.

[Lei Zhang, 2016-04-13 00:56:06]

Description was changed from

==========
Cleanup CPDFXFA_Page.

- Use std::unique_ptr.
- Make dtor protected.
- Simplify logic.
==========

to

==========
Cleanup CPDFXFA_Page.

- Use std::unique_ptr.
- Make dtor protected.
- Simplify logic.
- Remove unused bits from CXFA_FFPageView as well.
==========

[Lei Zhang, 2016-04-13 00:56:53]

https://codereview.chromium.org/1878963004/diff/20001/fpdfsdk/fpdfxfa/fpdfxfa...
File fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1878963004/diff/20001/fpdfsdk/fpdfxfa/fpdfxfa...
fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp:162: pPage->AddRef();
On 2016/04/12 23:40:00, Tom Sepez wrote:
> nit: pity this isn't called Retain(), then we could use CFX_RetainPtrs to try
> and auto-increment these ...

Ya, but that's another rabbit hole and I'm not going down it today. Will take
care of it later.

https://codereview.chromium.org/1878963004/diff/20001/fpdfsdk/fpdfxfa/fpdfxfa...
File fpdfsdk/fpdfxfa/fpdfxfa_page.cpp (right):

https://codereview.chromium.org/1878963004/diff/20001/fpdfsdk/fpdfxfa/fpdfxfa...
fpdfsdk/fpdfxfa/fpdfxfa_page.cpp:76: m_pXFAPageView->LoadPageView(nullptr);
On 2016/04/12 23:40:00, Tom Sepez wrote:
> nit: I think this (void) was shorthand for // FIXME: check return value.

Not worth checking. See next patch set.

https://codereview.chromium.org/1878963004/diff/40001/xfa/fxfa/app/xfa_ffpage...
File xfa/fxfa/app/xfa_ffpageview.cpp (left):

https://codereview.chromium.org/1878963004/diff/40001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:46: int32_t
CXFA_FFPageView::LoadPageView(IFX_Pause* pPause) {
Uhh.

https://codereview.chromium.org/1878963004/diff/40001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:53: void CXFA_FFPageView::UnloadPageView() {
Unused.

https://codereview.chromium.org/1878963004/diff/40001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:58: FX_BOOL CXFA_FFPageView::IsPageViewLoaded()
{
Unused.

https://codereview.chromium.org/1878963004/diff/40001/xfa/fxfa/app/xfa_ffpage...
xfa/fxfa/app/xfa_ffpageview.cpp:61: CXFA_FFWidget*
CXFA_FFPageView::GetWidgetByPos(FX_FLOAT fx, FX_FLOAT fy) {
Oh, also unused.

[Lei Zhang, 2016-04-13 19:12:19]

Please take another look since I removed more stuff.

[Tom Sepez, 2016-04-13 20:08:56]

lgtm.

[Lei Zhang, 2016-04-13 20:17:55]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:18:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878963004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878963004/60001

[commit-bot: I haz the power, 2016-04-13 20:18:26]

Description was changed from

==========
Cleanup CPDFXFA_Page.

- Use std::unique_ptr.
- Make dtor protected.
- Simplify logic.
- Remove unused bits from CXFA_FFPageView as well.
==========

to

==========
Cleanup CPDFXFA_Page.

- Use std::unique_ptr.
- Make dtor protected.
- Simplify logic.
- Remove unused bits from CXFA_FFPageView as well.

Committed:
https://pdfium.googlesource.com/pdfium/+/9f3dbbc54c6981f069b57e6714393ac6c0c6...
==========

[commit-bot: I haz the power, 2016-04-13 20:18:27]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/9f3dbbc54c6981f069b57e6714393ac6c0c6...