Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1878963003: Convert BookmarkBubbleAppView to a DialogDelegateView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index b70e6894943347138db898f90c6c09bdb6e62aac..d485aca52baa9f83bbb3d6f2f7fbcdb2c5d92215 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -69,7 +69,7 @@
#include "chrome/browser/ui/views/download/download_shelf_view.h"
#include "chrome/browser/ui/views/edit_search_engine_dialog.h"
#include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
-#include "chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h"
+#include "chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h"
#include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h"
#include "chrome/browser/ui/views/find_bar_host.h"
#include "chrome/browser/ui/views/frame/browser_view_layout.h"
@@ -1250,7 +1250,8 @@ void BrowserView::ShowBookmarkBubble(const GURL& url, bool already_bookmarked) {
void BrowserView::ShowBookmarkAppBubble(
const WebApplicationInfo& web_app_info,
const ShowBookmarkAppBubbleCallback& callback) {
- BookmarkAppBubbleView::ShowBubble(GetToolbarView(), web_app_info, callback);
+ BookmarkAppConfirmationView::CreateAndShow(GetNativeWindow(), web_app_info,
+ callback);
}
autofill::SaveCardBubbleView* BrowserView::ShowSaveCreditCardBubble(
« no previous file with comments | « chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698