Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1878943014: Roll src/third_party/leveldatabase 7306ef85..a7bff697b (4 commits). (Closed)

Created:
4 years, 8 months ago by cmumford
Modified:
4 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/leveldatabase 7306ef85..a7bff697b (4 commits). * Deleted redundant null ptr check prior to delete. * Fixes a bug encountered when reading records from leveldb files that have been split, as in a [] input task split. * Change std::uint64_t to uint64_t (#354). * Fix LevelDB build when asserts are enabled in release builds. (#367). BUG=603166 Committed: https://crrev.com/b5bcbc691900b666542cce8e0d04f0472bcd981a Cr-Commit-Position: refs/heads/master@{#387695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
cmumford
4 years, 8 months ago (2016-04-15 18:09:56 UTC) #2
jam
lgtm, thanks!
4 years, 8 months ago (2016-04-15 19:20:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878943014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878943014/1
4 years, 8 months ago (2016-04-15 20:09:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 21:11:47 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 21:13:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5bcbc691900b666542cce8e0d04f0472bcd981a
Cr-Commit-Position: refs/heads/master@{#387695}

Powered by Google App Engine
This is Rietveld 408576698