Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1878943011: CL for perf tryjob on linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index c079c45a8dc3a093c1e40d014338ff64a531a0f9..87f7839c2573e38f404265a6ace9812c3b8cc6f4 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -246,6 +246,24 @@ void FrameView::forAllNonThrottledFrameViews(Function function)
}
}
+void FrameView::showFrameTree(int indent) const
+{
+ if (indent) {
+ for (int i = 0; i < indent; ++i)
+ fputc(' ', stderr);
+ } else {
+ fprintf(stderr, "Current frame tree:\n");
+ }
+ fprintf(stderr, "%p throttled: %d\n", this, shouldThrottleRendering());
+
+ for (Frame* child = m_frame->tree().firstChild(); child; child = child->tree().nextSibling()) {
+ if (!child->isLocalFrame())
+ continue;
+ if (FrameView* childView = toLocalFrame(child)->view())
+ childView->showFrameTree(indent + 2);
+ }
+}
+
void FrameView::init()
{
reset();
@@ -844,6 +862,7 @@ PassOwnPtr<TracedValue> FrameView::analyzerCounters()
void FrameView::performLayout(bool inSubtreeLayout)
{
+ fprintf(stderr, "FrameView %p performLayout\n", this);
ASSERT(inSubtreeLayout || m_layoutSubtreeRootList.isEmpty());
TRACE_EVENT_BEGIN0(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout");
@@ -1792,6 +1811,7 @@ void FrameView::scheduleRelayout()
if (m_hasPendingLayout)
return;
+ fprintf(stderr, "FrameView %p is set hasPendingLayout. throttle: %d\n", this, shouldThrottleRendering());
m_hasPendingLayout = true;
if (!shouldThrottleRendering())
@@ -1819,6 +1839,7 @@ void FrameView::scheduleRelayoutOfSubtree(LayoutObject* relayoutRoot)
m_layoutSubtreeRootList.add(*relayoutRoot);
if (m_layoutSchedulingEnabled) {
+ fprintf(stderr, "FrameView %p is set hasPendingLayout in scheduleRelayoutOfSubtree. throttle: %d\n", this, shouldThrottleRendering());
m_hasPendingLayout = true;
page()->animator().scheduleVisualUpdate(m_frame.get());
@@ -2399,6 +2420,8 @@ void FrameView::scheduleVisualUpdateForPaintInvalidationIfNeeded()
// TODO(leviw): We don't assert lifecycle information from documents in child PluginViews.
void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases)
{
+ showFrameTree();
+
Optional<TemporaryChange<bool>> isUpdatingAllLifecyclePhasesScope;
if (phases == AllPhases)
isUpdatingAllLifecyclePhasesScope.emplace(m_isUpdatingAllLifecyclePhases, true);
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698