Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
187893004:
don't need to create SkBitmapDevice -- which is deprecated from the public API (Closed)
|
Created:
6 years, 9 months ago by reed1 Modified:
6 years, 9 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Descriptiondon't need to create SkBitmapDevice -- which is deprecated from the public API
this one file was lifted from https://codereview.chromium.org/184743002/ and then modified to erase the bitmap when it is not marked as opaque. This restores the previous behavior when we were explicitly creating SkBitmapDevice.
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255319
Patch Set 1 #Patch Set 2 : #
Total comments: 4
Patch Set 3 : address style nits #Messages
Total messages: 22 (0 generated)
lgtm from the Skia perspective
mac failure in trybot does not seem related to this CL. linux success mirrors what I saw locally: previous version did fail in valgrind, but current version passes.
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/187893004/20001
lgtm w/ nits https://codereview.chromium.org/187893004/diff/20001/media/filters/skcanvas_v... File media/filters/skcanvas_video_renderer_unittest.cc (right): https://codereview.chromium.org/187893004/diff/20001/media/filters/skcanvas_v... media/filters/skcanvas_video_renderer_unittest.cc:81: static SkBitmap alloc_bitmap(int width, int height, bool isOpaque) { chromium naming nits: alloc_bitmap -> AllocBitmap isOpaque -> is_opaque https://codereview.chromium.org/187893004/diff/20001/media/filters/skcanvas_v... media/filters/skcanvas_video_renderer_unittest.cc:82: SkAlphaType alphaType = isOpaque ? kOpaque_SkAlphaType : kPremul_SkAlphaType; alphaType -> alpha_type
The CQ bit was unchecked by reed@google.com
https://codereview.chromium.org/187893004/diff/20001/media/filters/skcanvas_v... File media/filters/skcanvas_video_renderer_unittest.cc (right): https://codereview.chromium.org/187893004/diff/20001/media/filters/skcanvas_v... media/filters/skcanvas_video_renderer_unittest.cc:81: static SkBitmap alloc_bitmap(int width, int height, bool isOpaque) { On 2014/03/05 21:54:33, scherkus wrote: > chromium naming nits: > > alloc_bitmap -> AllocBitmap > isOpaque -> is_opaque Done. https://codereview.chromium.org/187893004/diff/20001/media/filters/skcanvas_v... media/filters/skcanvas_video_renderer_unittest.cc:82: SkAlphaType alphaType = isOpaque ? kOpaque_SkAlphaType : kPremul_SkAlphaType; On 2014/03/05 21:54:33, scherkus wrote: > alphaType -> alpha_type Done.
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/187893004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/187893004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
win_rel failure is in an unrelated unittest (browser/url), and my CL only changes a different unittest (media).
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/187893004/40001
Message was sent while issue was closed.
Change committed as 255319 |
