Use injection and remove ozone dependency from ui/display

Use injection and remove ozone dependency from ui/display

I'm moving display stuff to ui/display. This is necessary because ui/base depends on display stuff.

BUG=597761
Committed: https://crrev.com/e001c8c851a36216a5d9e5ca532e7276962c3d5a
Cr-Commit-Position: refs/heads/master@{#387155}

[oshima, 2016-04-12 00:29:48]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 00:30:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/1

[commit-bot: I haz the power, 2016-04-12 00:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 00:45:06]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[oshima, 2016-04-12 01:16:12]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 01:16:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/20001

[commit-bot: I haz the power, 2016-04-12 01:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 01:38:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-04-12 01:43:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 01:44:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/40001

[commit-bot: I haz the power, 2016-04-12 01:55:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 01:55:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2016-04-12 02:43:42]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 02:44:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/60001

[commit-bot: I haz the power, 2016-04-12 02:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 02:53:51]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2016-04-12 05:54:00]

Patchset #1 (id:1) has been deleted

[oshima, 2016-04-12 05:54:08]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-04-12 05:54:16]

Patchset #1 (id:40001) has been deleted

[oshima, 2016-04-12 06:32:10]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 06:32:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/80001

[commit-bot: I haz the power, 2016-04-12 06:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 06:41:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2016-04-12 16:49:22]

Patchset #1 (id:60001) has been deleted

[oshima, 2016-04-12 16:51:46]

Description was changed from

==========
Remove ozone dependency from ui/display

BUG=597761
==========

to

==========
Remove ozone dependency from ui/display

* Use injection instead.

BUG=597761
==========

[oshima, 2016-04-12 16:51:46]

oshima@chromium.org changed reviewers:
+ spang@chromium.org

[oshima, 2016-04-12 16:59:35]

Description was changed from

==========
Remove ozone dependency from ui/display

* Use injection instead.

BUG=597761
==========

to

==========
Use injection and remove ozone dependency from ui/display

I'm moving display stuff to ui/display. This is necessary because ui/base
depends on display stuff.

BUG=597761
==========

[oshima, 2016-04-12 16:59:41]

https://codereview.chromium.org/1878903002/diff/80001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1878903002/diff/80001/ash/shell.cc#newcode880
ash/shell.cc:880: !gpu_support_->IsPanelFittingDisabled());
I'm assuming that NativeDisplayDelegateX11 will be replaced with ozone x11 soon.

[oshima, 2016-04-13 17:38:10]

ping?

[spang, 2016-04-13 17:55:15]

lgtm

[oshima, 2016-04-13 18:29:54]

oshima@chromium.org changed reviewers:
+ dalecurtis@chromium.org, jamescook@chromium.org

[oshima, 2016-04-13 18:29:55]

jamescook@ -> extension/shell owner
dalecurtis@ -> content/common/gpu/media owner

[DaleCurtis, 2016-04-13 20:52:31]

media/ lgtm

[oshima, 2016-04-13 20:56:14]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 20:56:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/100001

[commit-bot: I haz the power, 2016-04-13 21:10:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 21:10:45]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[oshima, 2016-04-13 21:28:33]

Patchset #3 (id:120001) has been deleted

[oshima, 2016-04-13 21:36:58]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 21:37:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/140001

[commit-bot: I haz the power, 2016-04-13 21:58:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 21:58:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-04-13 22:26:46]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 22:27:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/160001

[James Cook, 2016-04-13 23:36:16]

extensions/shell lgtm

[commit-bot: I haz the power, 2016-04-13 23:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 23:37:55]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-04-13 23:41:59]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-04-13 23:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from spang@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1878903002/#ps160001
(title: "fix unique_ptr")

[commit-bot: I haz the power, 2016-04-13 23:42:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878903002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878903002/160001

[commit-bot: I haz the power, 2016-04-13 23:49:14]

Description was changed from

==========
Use injection and remove ozone dependency from ui/display

I'm moving display stuff to ui/display. This is necessary because ui/base
depends on display stuff.

BUG=597761
==========

to

==========
Use injection and remove ozone dependency from ui/display

I'm moving display stuff to ui/display. This is necessary because ui/base
depends on display stuff.

BUG=597761
==========

[commit-bot: I haz the power, 2016-04-13 23:49:15]

Committed patchset #4 (id:160001)

[commit-bot: I haz the power, 2016-04-13 23:51:22]

Description was changed from

==========
Use injection and remove ozone dependency from ui/display

I'm moving display stuff to ui/display. This is necessary because ui/base
depends on display stuff.

BUG=597761
==========

to

==========
Use injection and remove ozone dependency from ui/display

I'm moving display stuff to ui/display. This is necessary because ui/base
depends on display stuff.

BUG=597761

Committed: https://crrev.com/e001c8c851a36216a5d9e5ca532e7276962c3d5a
Cr-Commit-Position: refs/heads/master@{#387155}
==========

[commit-bot: I haz the power, 2016-04-13 23:51:24]

Patchset 4 (id:??) landed as
https://crrev.com/e001c8c851a36216a5d9e5ca532e7276962c3d5a
Cr-Commit-Position: refs/heads/master@{#387155}