Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1878893004: [Interpreter] Updates mjsunit.status. (Closed)

Created:
4 years, 8 months ago by mythria
Modified:
4 years, 8 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Updates mjsunit.status. Removes skips for two tests that no longer fail on windows system. Updates description of another failing test with more details. BUG=v8:4280, v8:4680 LOG=N Committed: https://crrev.com/7effb4f7369fc6f1c623285ef86c52bc1b30fdb3 Cr-Commit-Position: refs/heads/master@{#35475}

Patch Set 1 #

Patch Set 2 : removing skip for one more test on windows. #

Patch Set 3 : Updates description of a failing test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M test/mjsunit/mjsunit.status View 1 2 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878893004/1
4 years, 8 months ago (2016-04-13 11:47:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878893004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878893004/20001
4 years, 8 months ago (2016-04-13 13:25:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4187)
4 years, 8 months ago (2016-04-13 13:28:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878893004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878893004/40001
4 years, 8 months ago (2016-04-13 15:09:56 UTC) #10
mythria
Both of them seem to be working on all windows bots. PTAL. Thanks, Mythri
4 years, 8 months ago (2016-04-13 15:10:37 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 15:33:40 UTC) #14
rmcilroy
lgtm, thanks
4 years, 8 months ago (2016-04-13 16:10:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878893004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878893004/40001
4 years, 8 months ago (2016-04-14 08:57:58 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-14 08:59:59 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 09:01:46 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7effb4f7369fc6f1c623285ef86c52bc1b30fdb3
Cr-Commit-Position: refs/heads/master@{#35475}

Powered by Google App Engine
This is Rietveld 408576698