Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1878893003:
Ensure tapped Physical Web links open in a new tab (Closed)
DescriptionEnsure tapped Physical Web links open in a new tab
Prior to this change, tapping on a physical web link would open the
URL, but then if one were to close chrome (e.g. by hitting the home
button, etc.) and then tap the chrome launcher, they would go back
to the physical web activity and not the opened content as expected.
This change opens the link in a new tab so that closing/reopening
behavior works as expected.
BUG=601161
Committed: https://crrev.com/6470dc869611cd9f7adfe6200c83fcace8ae35ec
Cr-Commit-Position: refs/heads/master@{#392172}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Expand commit description #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Ensure tapped Physical Web links open in a new tab BUG=601161 ========== to ========== Ensure tapped Physical Web links open in a new tab BUG=601161 ==========
cco3@chromium.org changed reviewers: + agrieve@chromium.org, mattreynolds@chromium.org
https://codereview.chromium.org/1878893003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (right): https://codereview.chromium.org/1878893003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:381: .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); Does this actually open in a new Android task? Or is this just how you tell Chrome to open in a new tab?
https://codereview.chromium.org/1878893003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (right): https://codereview.chromium.org/1878893003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:381: .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); On 2016/05/04 20:27:15, mattreynolds wrote: > Does this actually open in a new Android task? Or is this just how you tell > Chrome to open in a new tab? NEW_TASK is poorly named. It just means "don't open it on my task stack"
lgtm
cco3@chromium.org changed reviewers: + nyquist@chromium.org
lgtm, but could you please expand the CL description? One paragraph for each of these questions would be super helpful: 1) What is currently happening before your CL? 2) Why is that bad? 3) How does this CL make it better? That would make it much easier to read in the future when browsing the commit log.
Description was changed from ========== Ensure tapped Physical Web links open in a new tab BUG=601161 ========== to ========== Ensure tapped Physical Web links open in a new tab Prior to this change, tapping on a physical web link would open the URL, but then if one were to close chrome (e.g. by hitting the home button, etc.) and then tap the chrome launcher, they would go back to the physical web activity and not the opened content as expected. This change opens the link in a new tab so that closing/reopening behavior works as expected. BUG=601161 ==========
The CQ bit was checked by cco3@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org, mattreynolds@chromium.org Link to the patchset: https://codereview.chromium.org/1878893003/#ps20001 (title: "Expand commit description")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878893003/20001
Message was sent while issue was closed.
Description was changed from ========== Ensure tapped Physical Web links open in a new tab Prior to this change, tapping on a physical web link would open the URL, but then if one were to close chrome (e.g. by hitting the home button, etc.) and then tap the chrome launcher, they would go back to the physical web activity and not the opened content as expected. This change opens the link in a new tab so that closing/reopening behavior works as expected. BUG=601161 ========== to ========== Ensure tapped Physical Web links open in a new tab Prior to this change, tapping on a physical web link would open the URL, but then if one were to close chrome (e.g. by hitting the home button, etc.) and then tap the chrome launcher, they would go back to the physical web activity and not the opened content as expected. This change opens the link in a new tab so that closing/reopening behavior works as expected. BUG=601161 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Ensure tapped Physical Web links open in a new tab Prior to this change, tapping on a physical web link would open the URL, but then if one were to close chrome (e.g. by hitting the home button, etc.) and then tap the chrome launcher, they would go back to the physical web activity and not the opened content as expected. This change opens the link in a new tab so that closing/reopening behavior works as expected. BUG=601161 ========== to ========== Ensure tapped Physical Web links open in a new tab Prior to this change, tapping on a physical web link would open the URL, but then if one were to close chrome (e.g. by hitting the home button, etc.) and then tap the chrome launcher, they would go back to the physical web activity and not the opened content as expected. This change opens the link in a new tab so that closing/reopening behavior works as expected. BUG=601161 Committed: https://crrev.com/6470dc869611cd9f7adfe6200c83fcace8ae35ec Cr-Commit-Position: refs/heads/master@{#392172} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6470dc869611cd9f7adfe6200c83fcace8ae35ec Cr-Commit-Position: refs/heads/master@{#392172} |
