Move //mojo/services tracing & catalog to //services

Move //mojo/services tracing & catalog to //services.

TBR=jam@chromium.org
BUG=

Committed: https://crrev.com/7095d1a47fe3897b1a7f9d43a25f05cb1af3ea8b
Cr-Commit-Position: refs/heads/master@{#386921}

[Ben Goodger (Google), 2016-04-12 01:28:12]

Description was changed from

==========
Move //mojo/services tracing & catalog to //services.

TBR=jam@chromium.org
BUG=
==========

to

==========
Move //mojo/services tracing & catalog to //services.

TBR=jam@chromium.org
BUG=
==========

[jam, 2016-04-12 16:04:38]

lgtm

[Ben Goodger (Google), 2016-04-12 22:49:25]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-12 22:49:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878893002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2016-04-12 22:49:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878893002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878893002/120001

[commit-bot: I haz the power, 2016-04-12 22:56:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 22:56:14]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-04-12 23:02:14]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-12 23:02:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878893002/#ps140001
(title: ".")

[commit-bot: I haz the power, 2016-04-12 23:02:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878893002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878893002/140001

[commit-bot: I haz the power, 2016-04-12 23:10:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 23:10:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-04-12 23:16:50]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-12 23:16:51]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878893002/#ps160001
(title: ".")

[commit-bot: I haz the power, 2016-04-12 23:17:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878893002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878893002/160001

[commit-bot: I haz the power, 2016-04-12 23:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 23:25:13]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2016-04-13 00:01:10]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-13 00:01:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878893002/#ps180001
(title: ".")

[commit-bot: I haz the power, 2016-04-13 00:01:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878893002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878893002/180001

[commit-bot: I haz the power, 2016-04-13 00:08:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 00:08:55]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-04-13 02:03:49]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-13 02:03:51]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878893002/#ps200001
(title: ".")

[commit-bot: I haz the power, 2016-04-13 02:04:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878893002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878893002/200001

[commit-bot: I haz the power, 2016-04-13 02:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 02:20:23]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Ben Goodger (Google), 2016-04-13 03:07:24]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-13 03:07:25]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878893002/#ps220001
(title: ".")

[commit-bot: I haz the power, 2016-04-13 03:07:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878893002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878893002/220001

[commit-bot: I haz the power, 2016-04-13 03:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 03:25:43]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Ben Goodger (Google), 2016-04-13 03:43:14]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-13 03:43:16]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878893002/#ps240001
(title: ".")

[commit-bot: I haz the power, 2016-04-13 03:43:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878893002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878893002/240001

[commit-bot: I haz the power, 2016-04-13 04:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 04:02:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-04-13 04:10:57]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-13 04:10:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878893002/#ps260001
(title: ".")

[commit-bot: I haz the power, 2016-04-13 04:11:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878893002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878893002/260001

[commit-bot: I haz the power, 2016-04-13 06:15:08]

Description was changed from

==========
Move //mojo/services tracing & catalog to //services.

TBR=jam@chromium.org
BUG=
==========

to

==========
Move //mojo/services tracing & catalog to //services.

TBR=jam@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-04-13 06:15:10]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-04-13 06:16:33]

Description was changed from

==========
Move //mojo/services tracing & catalog to //services.

TBR=jam@chromium.org
BUG=
==========

to

==========
Move //mojo/services tracing & catalog to //services.

TBR=jam@chromium.org
BUG=

Committed: https://crrev.com/7095d1a47fe3897b1a7f9d43a25f05cb1af3ea8b
Cr-Commit-Position: refs/heads/master@{#386921}
==========

[commit-bot: I haz the power, 2016-04-13 06:16:36]

Patchset 14 (id:??) landed as
https://crrev.com/7095d1a47fe3897b1a7f9d43a25f05cb1af3ea8b
Cr-Commit-Position: refs/heads/master@{#386921}

[Nico, 2016-04-13 12:42:35]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-04-13 12:42:37]

I'm seeing this now:

FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool
link-with-manifests environment.x86 True mojo_shell_unittests.exe
"C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper
environment.x86 False link.exe /nologo /OUT:mojo_shell_unittests.exe
@mojo_shell_unittests.exe.rsp" 1 mt.exe rc.exe
"obj\services\shell\mojo_shell_unittests.mojo_shell_unittests.exe.intermediate.manifest"
obj\services\shell\mojo_shell_unittests.mojo_shell_unittests.exe.generated.manifest
..\..\build\win\compatibility.manifest
LINK : fatal error LNK1104: cannot open file
'obj\services\shell\shell_test_interfaces.lib'


e.g. here:
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds...

Does that error make sense to you?

[bajones, 2016-04-13 17:25:06]

On 2016/04/13 12:42:37, Nico wrote:
> I'm seeing this now:
> 
> FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool
> link-with-manifests environment.x86 True mojo_shell_unittests.exe
> "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper
> environment.x86 False link.exe /nologo /OUT:mojo_shell_unittests.exe
> @mojo_shell_unittests.exe.rsp" 1 mt.exe rc.exe
>
"obj\services\shell\mojo_shell_unittests.mojo_shell_unittests.exe.intermediate.manifest"
>
obj\services\shell\mojo_shell_unittests.mojo_shell_unittests.exe.generated.manifest
> ..\..\build\win\compatibility.manifest
> LINK : fatal error LNK1104: cannot open file
> 'obj\services\shell\shell_test_interfaces.lib'
> 
> 
> e.g. here:
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds...
> 
> Does that error make sense to you?

I'm also seeing the same failure on the GPU Win Clang builder
(https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Clang%20Bu...)
that looks like it can be traced back to this commit:

FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool
link-with-manifests environment.x86 True mojo_shell_unittests.exe
"E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper
environment.x86 False link.exe /nologo /OUT:mojo_shell_unittests.exe
@mojo_shell_unittests.exe.rsp" 1 mt.exe rc.exe
"obj\services\shell\mojo_shell_unittests.mojo_shell_unittests.exe.intermediate.manifest"
obj\services\shell\mojo_shell_unittests.mojo_shell_unittests.exe.generated.manifest
..\..\build\win\compatibility.manifest

Sample output here:
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Clang%20Bu...

Can we revert this commit?

[Nico, 2016-04-13 17:26:11]

a fix just landed: https://codereview.chromium.org/1879403002/ (spent too long
in the cq due to flakes, but it's in now)