Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1878863004: Revert of Record call site history in LeakDetectorImpl (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 8 months ago
Reviewers:
Will Harris, Simon Que
CC:
chromium-reviews, asvitkine+watch_chromium.org, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Record call site history in LeakDetectorImpl (patchset #3 id:40001 of https://codereview.chromium.org/1870233003/ ) Reason for revert: Broke ChromeOS ASAN and MSAN bots. Links to failures are on the original code review. Original issue's description: > Record call site history in LeakDetectorImpl > > Recording a history of the call sites with the most allocations gives us a > better picture of the allocation patterns leading up to a suspected leak > being found. This is useful data that is relatively easy to obtain -- it is > already being processed by the Leak Detector, just have to record it. > > BUG=chromium:382705 > TEST=unit tests pass > > Committed: https://crrev.com/c9487e8d00805addbbb847f662a39d3258063ac6 > Cr-Commit-Position: refs/heads/master@{#386500} TBR=wfh@chromium.org,sque@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:382705 Committed: https://crrev.com/221cc4922e5e889dea7474d463748a3fbd1158b3 Cr-Commit-Position: refs/heads/master@{#386541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -266 lines) Patch
M components/metrics/leak_detector/leak_detector_impl.h View 5 chunks +6 lines, -47 lines 0 comments Download
M components/metrics/leak_detector/leak_detector_impl.cc View 6 chunks +18 lines, -87 lines 0 comments Download
M components/metrics/leak_detector/leak_detector_impl_unittest.cc View 4 chunks +36 lines, -67 lines 0 comments Download
M components/metrics/leak_detector/ranked_set.h View 1 chunk +0 lines, -13 lines 0 comments Download
M components/metrics/leak_detector/ranked_set.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M components/metrics/leak_detector/ranked_set_unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
Created Revert of Record call site history in LeakDetectorImpl
4 years, 8 months ago (2016-04-12 01:09:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878863004/1
4 years, 8 months ago (2016-04-12 01:10:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 01:10:53 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 01:12:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/221cc4922e5e889dea7474d463748a3fbd1158b3
Cr-Commit-Position: refs/heads/master@{#386541}

Powered by Google App Engine
This is Rietveld 408576698