Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1883)

Unified Diff: content/shell/browser/layout_test/blink_test_controller.h

Issue 1878863002: Replicate LayoutTestRuntimeFlags across secondary window renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicate-web-content-settings
Patch Set: Extracted half of changes to https://crrev.com/1890223002 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/blink_test_controller.h
diff --git a/content/shell/browser/layout_test/blink_test_controller.h b/content/shell/browser/layout_test/blink_test_controller.h
index ea352288b4f07109ce0b8606bf0950941db8ec94..50732b7bf452db024a80f5cae614e0cdc4784009 100644
--- a/content/shell/browser/layout_test/blink_test_controller.h
+++ b/content/shell/browser/layout_test/blink_test_controller.h
@@ -134,6 +134,12 @@ class BlinkTestController : public base::NonThreadSafe,
// True if the controller was reset successfully.
bool ResetAfterLayoutTest();
+ // IPC messages forwarded from elsewhere.
+ void OnLayoutTestRuntimeFlagsChanged(
+ int sender_process_host_id,
+ const base::DictionaryValue& changed_layout_test_runtime_flags);
+ void OnTestFinishedInSecondaryRenderer();
+
// Makes sure that the potentially new renderer associated with |frame| is 1)
// initialized for the test, 2) kept-up-to-date wrt test flags and 3)
// monitored for crashes.
@@ -143,7 +149,6 @@ class BlinkTestController : public base::NonThreadSafe,
void RendererUnresponsive();
void OverrideWebkitPrefs(WebPreferences* prefs);
void OpenURL(const GURL& url);
- void TestFinishedInSecondaryRenderer();
bool IsMainWindow(WebContents* web_contents) const;
std::unique_ptr<BluetoothChooser> RunBluetoothChooser(
RenderFrameHost* frame,
@@ -196,9 +201,6 @@ class BlinkTestController : public base::NonThreadSafe,
void OnImageDump(const std::string& actual_pixel_hash, const SkBitmap& image);
void OnTextDump(const std::string& dump);
void OnInitiateLayoutDump();
- void OnLayoutTestRuntimeFlagsChanged(
- RenderFrameHost* sender,
- const base::DictionaryValue& changed_layout_test_runtime_flags);
void OnLayoutDumpResponse(RenderFrameHost* sender, const std::string& dump);
void OnPrintMessage(const std::string& message);
void OnOverridePreferences(const WebPreferences& prefs);

Powered by Google App Engine
This is Rietveld 408576698