Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

Issue 1878863002: Replicate LayoutTestRuntimeFlags across secondary window renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicate-web-content-settings
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
index 8638d3df10487f3a2e12ef7d23226307ded58ba7..e86a22611c5331424ff9d05bde1b06310984fd66 100644
--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
@@ -32,8 +32,6 @@ bool LayoutTestRenderFrameObserver::OnMessageReceived(
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(LayoutTestRenderFrameObserver, message)
IPC_MESSAGE_HANDLER(ShellViewMsg_LayoutDumpRequest, OnLayoutDumpRequest)
- IPC_MESSAGE_HANDLER(ShellViewMsg_ReplicateLayoutTestRuntimeFlagsChanges,
- OnReplicateLayoutTestRuntimeFlagsChanges)
IPC_MESSAGE_HANDLER(ShellViewMsg_ReplicateTestConfiguration,
OnReplicateTestConfiguration)
IPC_MESSAGE_HANDLER(ShellViewMsg_SetTestConfiguration,
@@ -55,24 +53,10 @@ void LayoutTestRenderFrameObserver::OnLayoutDumpRequest() {
Send(new ShellViewHostMsg_LayoutDumpResponse(routing_id(), dump));
}
-void LayoutTestRenderFrameObserver::OnReplicateLayoutTestRuntimeFlagsChanges(
- const base::DictionaryValue& changed_layout_test_runtime_flags) {
- LayoutTestRenderThreadObserver::GetInstance()
- ->test_interfaces()
- ->TestRunner()
- ->ReplicateLayoutTestRuntimeFlagsChanges(
- changed_layout_test_runtime_flags);
-}
-
void LayoutTestRenderFrameObserver::OnReplicateTestConfiguration(
- const ShellTestConfiguration& test_config,
- const base::DictionaryValue&
- accumulated_layout_test_runtime_flags_changes) {
+ const ShellTestConfiguration& test_config) {
BlinkTestRunner::Get(render_frame()->GetRenderView())
->OnReplicateTestConfiguration(test_config);
-
- OnReplicateLayoutTestRuntimeFlagsChanges(
- accumulated_layout_test_runtime_flags_changes);
}
void LayoutTestRenderFrameObserver::OnSetTestConfiguration(

Powered by Google App Engine
This is Rietveld 408576698