Replicate LayoutTestRuntimeFlags across secondary window renderers.

Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

After this CL (and after the earlier https://crrev.com/1875303002)
flags controlling WebContentSettingsClient are replicated to secondary
renderers.  This means that a few extra mixed content layout tests
are passing in --site-per-process mode and allows to remove test
expectations for this mode.

BUG=587175, 582525, 595895
Committed: https://crrev.com/23c3a85fc9c33eecaec87d9cc85195dcdfb4b3aa
Cr-Commit-Position: refs/heads/master@{#387977}

[Łukasz Anforowicz, 2016-04-11 23:48:59]

Description was changed from

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated
across renderers with frames belonging to the main test window.
After this CL, LayoutTestRuntimeFlags are replicated across
all renderers (including renderers for secondary window frames).

BUG=587175, 582525
==========

to

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

To prevent a UaF that would otherwise happen after the replication, this
CL makes sure that WebViewTestClient uses a BlinkTestRunner (aka
WebTestDelegate) associated with the correct RenderView (one associated
with the given WebViewTestClient, rather than one taken from the global
TestInterfaces).  Eventually the global BlinkTestRunner interface should
also be cleaned up.

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

This CL makes adjustments to how renderer processes are configured
for a specific test.  BlinkTestRunner instances associated with the main
window continue to receive ShellViewMsg_ReplicateTestConfiguration and
ShellViewMsg_SetTestConfiguration messages, but we also introduce
hellViewMsg_SetupSecondaryRenderer message, which makes sure that
a secondary renderer starts with a clean slate of LayoutTestRuntimeFlags
(this used to be handled by BlinkTestRunner::Navigate method).
Note that when a main window frame appears in a secondary renderer,
we will still send ShellViewMsg_ReplicateTestConfiguration and promote
the renderer (i.e. setting BlinkTestRunner::is_main_window_).

Cleaning up BlinkTestRunner::Navigate method (and fixing up the target
BlinkTestRunner used by LayoytTestRenderFrameObserver) enables to remove
one occurence of a global field holding (an essentially non-global)
BlinkTestRunner - we can remove
LayoutTestRenderProcessObserver::main_test_runner_ field.

BUG=587175, 582525
==========

[Łukasz Anforowicz, 2016-04-12 00:16:15]

Description was changed from

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

To prevent a UaF that would otherwise happen after the replication, this
CL makes sure that WebViewTestClient uses a BlinkTestRunner (aka
WebTestDelegate) associated with the correct RenderView (one associated
with the given WebViewTestClient, rather than one taken from the global
TestInterfaces).  Eventually the global BlinkTestRunner interface should
also be cleaned up.

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

This CL makes adjustments to how renderer processes are configured
for a specific test.  BlinkTestRunner instances associated with the main
window continue to receive ShellViewMsg_ReplicateTestConfiguration and
ShellViewMsg_SetTestConfiguration messages, but we also introduce
hellViewMsg_SetupSecondaryRenderer message, which makes sure that
a secondary renderer starts with a clean slate of LayoutTestRuntimeFlags
(this used to be handled by BlinkTestRunner::Navigate method).
Note that when a main window frame appears in a secondary renderer,
we will still send ShellViewMsg_ReplicateTestConfiguration and promote
the renderer (i.e. setting BlinkTestRunner::is_main_window_).

Cleaning up BlinkTestRunner::Navigate method (and fixing up the target
BlinkTestRunner used by LayoytTestRenderFrameObserver) enables to remove
one occurence of a global field holding (an essentially non-global)
BlinkTestRunner - we can remove
LayoutTestRenderProcessObserver::main_test_runner_ field.

BUG=587175, 582525
==========

to

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

To prevent a UaF that would otherwise happen after the replication, this
CL makes sure that WebViewTestClient uses a BlinkTestRunner (aka
WebTestDelegate) associated with the correct RenderView (one associated
with the given WebViewTestClient, rather than one taken from the global
TestInterfaces).  Eventually the global BlinkTestRunner interface should
also be cleaned up.

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

This CL makes adjustments to how renderer processes are configured
for a specific test.  BlinkTestRunner instances associated with the main
window continue to receive ShellViewMsg_ReplicateTestConfiguration and
ShellViewMsg_SetTestConfiguration messages, but we also introduce
hellViewMsg_SetupSecondaryRenderer message, which makes sure that
a secondary renderer starts with a clean slate of LayoutTestRuntimeFlags
(this used to be handled by BlinkTestRunner::Navigate method).
Note that when a main window frame appears in a secondary renderer,
we will still send ShellViewMsg_ReplicateTestConfiguration and promote
the renderer (i.e. setting BlinkTestRunner::is_main_window_).

Cleaning up BlinkTestRunner::Navigate method (and fixing up the target
BlinkTestRunner used by LayoytTestRenderFrameObserver) enables to remove
one occurence of a global field holding (an essentially non-global)
BlinkTestRunner - we can now remove
LayoutTestRenderProcessObserver::main_test_runner_ field (and then
also remove LayoutTestRenderProcessObserver::SetMainWindow which
can be simply inlined into LayoutTestContentRendererClient).

BUG=587175, 582525
==========

[Łukasz Anforowicz, 2016-04-15 18:40:43]

Description was changed from

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

To prevent a UaF that would otherwise happen after the replication, this
CL makes sure that WebViewTestClient uses a BlinkTestRunner (aka
WebTestDelegate) associated with the correct RenderView (one associated
with the given WebViewTestClient, rather than one taken from the global
TestInterfaces).  Eventually the global BlinkTestRunner interface should
also be cleaned up.

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

This CL makes adjustments to how renderer processes are configured
for a specific test.  BlinkTestRunner instances associated with the main
window continue to receive ShellViewMsg_ReplicateTestConfiguration and
ShellViewMsg_SetTestConfiguration messages, but we also introduce
hellViewMsg_SetupSecondaryRenderer message, which makes sure that
a secondary renderer starts with a clean slate of LayoutTestRuntimeFlags
(this used to be handled by BlinkTestRunner::Navigate method).
Note that when a main window frame appears in a secondary renderer,
we will still send ShellViewMsg_ReplicateTestConfiguration and promote
the renderer (i.e. setting BlinkTestRunner::is_main_window_).

Cleaning up BlinkTestRunner::Navigate method (and fixing up the target
BlinkTestRunner used by LayoytTestRenderFrameObserver) enables to remove
one occurence of a global field holding (an essentially non-global)
BlinkTestRunner - we can now remove
LayoutTestRenderProcessObserver::main_test_runner_ field (and then
also remove LayoutTestRenderProcessObserver::SetMainWindow which
can be simply inlined into LayoutTestContentRendererClient).

BUG=587175, 582525
==========

to

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

After this CL (and after the earlier https://crrev.com/1875303002)
flags controlling WebContentSettingsClient are replicated to secondary
renderers.  This means that a few extra mixed content layout tests
are passing in --site-per-process mode and allows to remove test
expectations for this mode.

BUG=587175, 582525
==========

[Łukasz Anforowicz, 2016-04-15 20:17:51]

+dcheng@ to CC [this CL cleans up some code that we've discussed in the past]

https://codereview.chromium.org/1878863002/diff/80001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/1878863002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:716:
changed_layout_test_runtime_flags));
dcheng@ was (rightfully) unhappy about the shape of the old code.  Hopefully the
new code makes everyone happier :-)

https://codereview.chromium.org/1878863002/diff/80001/content/shell/renderer/...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1878863002/diff/80001/content/shell/renderer/...
content/shell/renderer/layout_test/blink_test_runner.cc:533: new
LayoutTestHostMsg_LayoutTestRuntimeFlagsChanged(changed_values));
dcheng@ was (rightfully) unhappy about the shape of the old code.  Hopefully the
new code makes everyone happier :-)

[Łukasz Anforowicz, 2016-04-15 20:19:24]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-04-15 20:19:24]

jochen@, could you please take a look?

In this CL, the refactorings from the last few CLs finally result in new tests
passing / in shrinking down the test expectations list for site-per-process.

[jochen (gone - plz use gerrit), 2016-04-17 17:11:37]

lgtm

[Łukasz Anforowicz, 2016-04-18 14:40:54]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 14:41:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878863002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878863002/80001

[commit-bot: I haz the power, 2016-04-18 14:43:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 14:43:39]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Łukasz Anforowicz, 2016-04-18 16:46:25]

Description was changed from

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

After this CL (and after the earlier https://crrev.com/1875303002)
flags controlling WebContentSettingsClient are replicated to secondary
renderers.  This means that a few extra mixed content layout tests
are passing in --site-per-process mode and allows to remove test
expectations for this mode.

BUG=587175, 582525
==========

to

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

After this CL (and after the earlier https://crrev.com/1875303002)
flags controlling WebContentSettingsClient are replicated to secondary
renderers.  This means that a few extra mixed content layout tests
are passing in --site-per-process mode and allows to remove test
expectations for this mode.

BUG=587175, 582525, 595895
==========

[Łukasz Anforowicz, 2016-04-18 17:42:12]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 17:42:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878863002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878863002/100001

[commit-bot: I haz the power, 2016-04-18 18:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 18:52:14]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-04-18 18:59:39]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-04-18 18:59:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1878863002/#ps100001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-04-18 19:00:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878863002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878863002/100001

[commit-bot: I haz the power, 2016-04-18 19:05:41]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-18 19:07:24]

Description was changed from

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

After this CL (and after the earlier https://crrev.com/1875303002)
flags controlling WebContentSettingsClient are replicated to secondary
renderers.  This means that a few extra mixed content layout tests
are passing in --site-per-process mode and allows to remove test
expectations for this mode.

BUG=587175, 582525, 595895
==========

to

==========
Replicate LayoutTestRuntimeFlags across secondary window renderers.

Before this CL, LayoutTestRuntimeFlags would only be replicated across
renderers with frames belonging to the main test window.  After this CL,
LayoutTestRuntimeFlags are replicated across all renderers (including
renderers for secondary window frames).

This CL also switches to use control/process IPC messages (rather than
RenderView messages) for propagating changes to LayoutTestRuntimeFlags.
This is desirable, because LayoutTestRuntimeFlags are a global object,
not really associated with a specific RenderView and/or BlinkTestRunner.
This is also nice from code clean-up perspective - this approach doesn't
need a swapped-out exception in LayoutTestContentClient and other
baroque pieces of code in BlinkTestRunner and BlinkTestController.
Regrettably, even after this CL, TestRunner continues to notify
the world about LayoutTestRuntimeFlags changes via an arbitrarily
picked BlinkTestRunner / WebTestDelegate.

After this CL (and after the earlier https://crrev.com/1875303002)
flags controlling WebContentSettingsClient are replicated to secondary
renderers.  This means that a few extra mixed content layout tests
are passing in --site-per-process mode and allows to remove test
expectations for this mode.

BUG=587175, 582525, 595895

Committed: https://crrev.com/23c3a85fc9c33eecaec87d9cc85195dcdfb4b3aa
Cr-Commit-Position: refs/heads/master@{#387977}
==========

[commit-bot: I haz the power, 2016-04-18 19:07:25]

Patchset 6 (id:??) landed as
https://crrev.com/23c3a85fc9c33eecaec87d9cc85195dcdfb4b3aa
Cr-Commit-Position: refs/heads/master@{#387977}