Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: core/fpdfapi/fpdf_parser/include/cpdf_array.h

Issue 1878803002: Add iterators and unit tests for CPDF_Array class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/fpdf_parser/include/cpdf_array.h
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_array.h b/core/fpdfapi/fpdf_parser/include/cpdf_array.h
index 506a6bc338b20000b4df4d57263fb361ce6d6804..2827e8513814c40971218dd92416b2aa5a3c2985 100644
--- a/core/fpdfapi/fpdf_parser/include/cpdf_array.h
+++ b/core/fpdfapi/fpdf_parser/include/cpdf_array.h
@@ -16,6 +16,9 @@
class CPDF_Array : public CPDF_Object {
public:
+ using Iterator = std::vector<CPDF_Object*>::iterator;
Tom Sepez 2016/04/12 00:29:17 These should be called iterator and const_iterator
Wei Li 2016/04/12 02:56:20 Done.
+ using ConstIterator = std::vector<CPDF_Object*>::const_iterator;
+
CPDF_Array();
// CPDF_Object.
@@ -58,6 +61,11 @@ class CPDF_Array : public CPDF_Object {
AddReference(pDoc, obj->GetObjNum());
}
+ Iterator begin() { return m_Objects.begin(); }
+ Iterator end() { return m_Objects.end(); }
+ ConstIterator begin() const { return m_Objects.begin(); }
+ ConstIterator end() const { return m_Objects.end(); }
+
protected:
~CPDF_Array() override;

Powered by Google App Engine
This is Rietveld 408576698