Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: core/fpdfapi/fpdf_parser/include/cpdf_array.h

Issue 1878803002: Add iterators and unit tests for CPDF_Array class (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Comment change Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_ARRAY_H_ 7 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_ARRAY_H_
8 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_ARRAY_H_ 8 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_ARRAY_H_
9 9
10 #include <vector> 10 #include <vector>
11 11
12 #include "core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h" 12 #include "core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h"
13 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h" 13 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"
14 #include "core/fxcrt/include/fx_basic.h" 14 #include "core/fxcrt/include/fx_basic.h"
15 #include "core/fxcrt/include/fx_coordinates.h" 15 #include "core/fxcrt/include/fx_coordinates.h"
16 16
17 class CPDF_Array : public CPDF_Object { 17 class CPDF_Array : public CPDF_Object {
18 public: 18 public:
19 using iterator = std::vector<CPDF_Object*>::iterator;
20 using const_iterator = std::vector<CPDF_Object*>::const_iterator;
21
19 CPDF_Array(); 22 CPDF_Array();
20 23
21 // CPDF_Object. 24 // CPDF_Object.
22 Type GetType() const override; 25 Type GetType() const override;
23 CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override; 26 CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override;
24 CPDF_Array* GetArray() const override; 27 CPDF_Array* GetArray() const override;
25 bool IsArray() const override; 28 bool IsArray() const override;
26 CPDF_Array* AsArray() override; 29 CPDF_Array* AsArray() override;
27 const CPDF_Array* AsArray() const override; 30 const CPDF_Array* AsArray() const override;
28 31
(...skipping 22 matching lines...) Expand all
51 void Add(CPDF_Object* pObj, CPDF_IndirectObjectHolder* pObjs = nullptr); 54 void Add(CPDF_Object* pObj, CPDF_IndirectObjectHolder* pObjs = nullptr);
52 void AddNumber(FX_FLOAT f); 55 void AddNumber(FX_FLOAT f);
53 void AddInteger(int i); 56 void AddInteger(int i);
54 void AddString(const CFX_ByteString& str); 57 void AddString(const CFX_ByteString& str);
55 void AddName(const CFX_ByteString& str); 58 void AddName(const CFX_ByteString& str);
56 void AddReference(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum); 59 void AddReference(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum);
57 void AddReference(CPDF_IndirectObjectHolder* pDoc, CPDF_Object* obj) { 60 void AddReference(CPDF_IndirectObjectHolder* pDoc, CPDF_Object* obj) {
58 AddReference(pDoc, obj->GetObjNum()); 61 AddReference(pDoc, obj->GetObjNum());
59 } 62 }
60 63
64 iterator begin() { return m_Objects.begin(); }
65 iterator end() { return m_Objects.end(); }
66 const_iterator begin() const { return m_Objects.begin(); }
67 const_iterator end() const { return m_Objects.end(); }
68
61 protected: 69 protected:
62 ~CPDF_Array() override; 70 ~CPDF_Array() override;
63 71
64 std::vector<CPDF_Object*> m_Objects; 72 std::vector<CPDF_Object*> m_Objects;
65 }; 73 };
66 74
67 #endif // CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_ARRAY_H_ 75 #endif // CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_ARRAY_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp ('k') | pdfium.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698