Add a dummy function CrashBug6500 so that the return...

net/base/tcp_client_socket_win.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/tcp_client_socket.h"
 
 #include "base/memory_debug.h"
 #include "base/string_util.h"
 #include "base/trace_event.h"
 #include "net/base/net_errors.h"
@@ skipping 181 matching lines @@
   int err = WSAGetLastError();
   if (err == WSA_IO_PENDING) {
     watcher_.StartWatching(overlapped_.hEvent, this);
     wait_state_ = WAITING_READ;
     callback_ = callback;
     return ERR_IO_PENDING;
   }
   return MapWinsockError(err);
 }
 
+// TODO(wtc): This temporary function is intended to determine the return
+// value and error code of the WaitForSingleObject call in
+// TCPClientSocket::Write if it doesn't return the expected WAIT_OBJECT_0.
+// See http://crbug.com/6500.
+static void CrashBug6500(DWORD wait_rv, DWORD wait_error) {
+  // wait_error is meaningful only if wait_rv is WAIT_FAILED.
+  CHECK(false) << wait_rv << wait_error;
+}
+
 int TCPClientSocket::Write(const char* buf,
                            int buf_len,
                            CompletionCallback* callback) {
   DCHECK(socket_ != INVALID_SOCKET);
   DCHECK(wait_state_ == NOT_WAITING);
   DCHECK(!callback_);
 
   buffer_.len = buf_len;
   buffer_.buf = const_cast<char*>(buf);
 
   TRACE_EVENT_BEGIN("socket.write", this, "");
   // TODO(wtc): Remove the CHECKs after enough testing.
   CHECK(WaitForSingleObject(overlapped_.hEvent, 0) == WAIT_TIMEOUT);
   DWORD num;
   int rv = WSASend(socket_, &buffer_, 1, &num, 0, &overlapped_, NULL);
   if (rv == 0) {
-    // TODO(wtc): These temporary CHECKs are intended to determine the return
-    // value and error code of the WaitForSingleObject call if it doesn't
-    // return the expected WAIT_OBJECT_0.  See http://crbug.com/6500.
     DWORD wait_rv = WaitForSingleObject(overlapped_.hEvent, 0);
     if (wait_rv != WAIT_OBJECT_0) {
-      if (wait_rv == WAIT_ABANDONED) {
-        CHECK(false);
-      } else if (wait_rv == WAIT_TIMEOUT) {
-        CHECK(false);
-      } else if (wait_rv == WAIT_FAILED) {
-        DWORD wait_error = GetLastError();
-        if (wait_error == ERROR_INVALID_HANDLE) {
-          CHECK(false);
-        } else {
-          CHECK(false);
-        }
-      } else {
-        CHECK(false);
-      }
+      DWORD wait_error = GetLastError();
+      CrashBug6500(wait_rv, wait_error);
     }
     BOOL ok = WSAResetEvent(overlapped_.hEvent);
     CHECK(ok);
     TRACE_EVENT_END("socket.write", this, StringPrintf("%d bytes", num));
     return static_cast<int>(num);
   }
   int err = WSAGetLastError();
   if (err == WSA_IO_PENDING) {
     watcher_.StartWatching(overlapped_.hEvent, this);
     wait_state_ = WAITING_WRITE;
@@ skipping 133 matching lines @@
       DidCompleteIO();
       break;
     default:
       NOTREACHED();
       break;
   }
 }
 
 }  // namespace net