Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1878763002: PRESUBMIT: Add GN bots to default trybots (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M PRESUBMIT.py View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_chromium
4 years, 8 months ago (2016-04-11 20:07:45 UTC) #1
kjellander_chromium
4 years, 8 months ago (2016-04-11 20:07:46 UTC) #2
kjellander_chromium
Committed patchset #1 (id:1) manually as 9cb0705771428941f973f526cbf0401a08dfe5a3 (presubmit successful).
4 years, 8 months ago (2016-04-11 20:08:01 UTC) #4
fbarchard
lgtm does android GN build actually work?
4 years, 8 months ago (2016-04-11 22:41:57 UTC) #5
kjellander_chromium
4 years, 8 months ago (2016-04-12 04:38:00 UTC) #6
Message was sent while issue was closed.
On 2016/04/11 22:41:57, fbarchard wrote:
> lgtm
> does android GN build actually work?

Yes, the bots in https://build.chromium.org/p/client.libyuv/ runs GN and
compiles fine.

Powered by Google App Engine
This is Rietveld 408576698