Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1878753002: Separate private headers for condition inclusion in BUILD file. (Closed)

Created:
4 years, 8 months ago by iroth
Modified:
4 years, 8 months ago
Reviewers:
dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M public.bzl View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
iroth
4 years, 8 months ago (2016-04-11 19:16:22 UTC) #3
dogben
lgtm
4 years, 8 months ago (2016-04-11 20:30:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878753002/1
4 years, 8 months ago (2016-04-11 20:31:32 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:45:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/849b175c029bcb5d4abb7fdadc45e8ed36f29a78

Powered by Google App Engine
This is Rietveld 408576698