[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/689885b8927231762450bbc82c4e50ec9fd716eb
Cr-Commit-Position: refs/heads/master@{#386747}

[mcasas, 2016-04-11 18:12:09]

Description was changed from

==========
[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
==========

to

==========
[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-04-11 18:33:33]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-04-11 20:09:15]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-04-11 22:00:36]

mcasas@chromium.org changed reviewers:
+ esprehn@chromium.org

[mcasas, 2016-04-11 22:00:36]

esprehn@ PTAL at the WebKit parts and the overall idea.

[mcasas, 2016-04-11 22:01:18]

Patchset #1 (id:40001) has been deleted

[esprehn, 2016-04-11 22:01:49]

lgtm

https://codereview.chromium.org/1878683002/diff/60001/content/renderer/wake_l...
File content/renderer/wake_lock/wake_lock_dispatcher.h (right):

https://codereview.chromium.org/1878683002/diff/60001/content/renderer/wake_l...
content/renderer/wake_lock/wake_lock_dispatcher.h:26:
blink::mojom::WakeLockServicePtr wake_lock_service_;
is this the naming convention others are using too?

[esprehn, 2016-04-11 22:02:06]

fyi I'm not an owner in content/browser so you'll need someone else to help
there.

[mcasas, 2016-04-11 22:05:31]

On 2016/04/11 22:02:06, esprehn wrote:
> fyi I'm not an owner in content/browser so you'll need someone else to help
> there.

Yeah! Just wanted to get your OK about where to put
the mojom in WebKit (i.e. Source/public/{module_name}
first of all. Will collect the remaining LGTMs. Cheers!

[mcasas, 2016-04-11 22:09:11]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org, xhwang@chromium.org

[mcasas, 2016-04-11 22:09:12]

avi@ RS content parts 
 ( include path adaptation and adding blink::
 to the mojom::WakeLockService class)

xhwang@ RS media/blink/BUILD.gn

https://codereview.chromium.org/1878683002/diff/60001/content/renderer/wake_l...
File content/renderer/wake_lock/wake_lock_dispatcher.h (right):

https://codereview.chromium.org/1878683002/diff/60001/content/renderer/wake_l...
content/renderer/wake_lock/wake_lock_dispatcher.h:26:
blink::mojom::WakeLockServicePtr wake_lock_service_;
On 2016/04/11 22:01:49, esprehn wrote:
> is this the naming convention others are using too?

I think so, moving mojom's to blink shifts them 
from content::mojom to blink::mojom, e.g. the 
usage of blink::mojom::PermissionService and 
blink::mojom::PermissionStatus in content/.

[xhwang, 2016-04-11 23:21:24]

On 2016/04/11 22:09:12, mcasas wrote:
> avi@ RS content parts 
>  ( include path adaptation and adding blink::
>  to the mojom::WakeLockService class)
> 
> xhwang@ RS media/blink/BUILD.gn
> 
>
https://codereview.chromium.org/1878683002/diff/60001/content/renderer/wake_l...
> File content/renderer/wake_lock/wake_lock_dispatcher.h (right):
> 
>
https://codereview.chromium.org/1878683002/diff/60001/content/renderer/wake_l...
> content/renderer/wake_lock/wake_lock_dispatcher.h:26:
> blink::mojom::WakeLockServicePtr wake_lock_service_;
> On 2016/04/11 22:01:49, esprehn wrote:
> > is this the naming convention others are using too?
> 
> I think so, moving mojom's to blink shifts them 
> from content::mojom to blink::mojom, e.g. the 
> usage of blink::mojom::PermissionService and 
> blink::mojom::PermissionStatus in content/.

Is it ever possible that WakeLock is useful outside of Blink/content? FYI, I am
planning to move PermissionService to components/ so it can be used in media/.
See https://chromiumcodereview.appspot.com/1838903007/

Also, see
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/927q3Jt9jKY.
We don't like "service" now. But since this CL only moves stuff, we can discuss
naming later.

[mcasas, 2016-04-11 23:27:26]

On 2016/04/11 23:21:24, xhwang wrote:
> On 2016/04/11 22:09:12, mcasas wrote:
> > avi@ RS content parts 
> >  ( include path adaptation and adding blink::
> >  to the mojom::WakeLockService class)
> > 
> > xhwang@ RS media/blink/BUILD.gn
> > 
> >
>
https://codereview.chromium.org/1878683002/diff/60001/content/renderer/wake_l...
> > File content/renderer/wake_lock/wake_lock_dispatcher.h (right):
> > 
> >
>
https://codereview.chromium.org/1878683002/diff/60001/content/renderer/wake_l...
> > content/renderer/wake_lock/wake_lock_dispatcher.h:26:
> > blink::mojom::WakeLockServicePtr wake_lock_service_;
> > On 2016/04/11 22:01:49, esprehn wrote:
> > > is this the naming convention others are using too?
> > 
> > I think so, moving mojom's to blink shifts them 
> > from content::mojom to blink::mojom, e.g. the 
> > usage of blink::mojom::PermissionService and 
> > blink::mojom::PermissionStatus in content/.
> 
> Is it ever possible that WakeLock is useful outside of Blink/content? FYI, I
am
> planning to move PermissionService to components/ so it can be used in media/.
> See https://chromiumcodereview.appspot.com/1838903007/
> 
> Also, see
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/927q3Jt9jKY.
> We don't like "service" now. But since this CL only moves stuff, we can
discuss
> naming later.

Duly noted, but both comments are beyond the scope of
this CL (that does not add/remove any code).

[xhwang, 2016-04-11 23:29:40]

medai/ rs LGTM

[dcheng, 2016-04-12 00:29:40]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-04-12 00:29:41]

mojoms need security review: can you make sure the moved mojom is still covered
by an OWNERS rule? Thanks.

[mcasas, 2016-04-12 16:35:00]

On 2016/04/12 00:29:41, dcheng wrote:
> mojoms need security review: can you make sure the moved mojom is still
covered
> by an OWNERS rule? Thanks.

Added OWNERS to public/platform/modules/wake_lock
with the .mojom security reviewers.

[Avi (use Gerrit), 2016-04-12 16:42:11]

lgtm

stamp

[Tom Sepez, 2016-04-12 16:48:41]

tsepez@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-04-12 16:48:41]

mojom LGTM

[mcasas, 2016-04-12 17:09:26]

Description was changed from

==========
[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-04-12 17:09:35]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-04-12 17:09:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1878683002/#ps80001
(title: "added OWNERS to public/platform/modules/wake_lock")

[commit-bot: I haz the power, 2016-04-12 17:09:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878683002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878683002/80001

[commit-bot: I haz the power, 2016-04-12 18:33:00]

Description was changed from

==========
[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-04-12 18:33:01]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-04-12 18:34:47]

Description was changed from

==========
[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[OnionSoup] Moving WakeLock Service to Blink (1/2): moving .mojom

This CL is part 1/2 of moving the WakeLockService renderer parts
from content/ to WebKit/. The complete transfer can be found in
https://crrev.com/1794553002, of which this is the .mojom moving
around parts. See bug for more info.

No new code is added.

BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/689885b8927231762450bbc82c4e50ec9fd716eb
Cr-Commit-Position: refs/heads/master@{#386747}
==========

[commit-bot: I haz the power, 2016-04-12 18:34:49]

Patchset 2 (id:??) landed as
https://crrev.com/689885b8927231762450bbc82c4e50ec9fd716eb
Cr-Commit-Position: refs/heads/master@{#386747}