MD Settings: allow subpages not wrapped in templates

chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Index: chrome/browser/resources/settings/settings_page/settings_animated_pages.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
index 574350715c0b614aee8cf2211cb636011b3f8352..4c994bc2aa8d6bd16c100f45d68b500ef49a97ba 100644
--- a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
+++ b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
@@ -127,8 +127,8 @@ Polymer({
     var template = Polymer.dom(this).querySelector(
         'template[name="' + id + '"]');
 
-    // Do nothing if the subpage is already stamped.
-    if (template.if)
+    // Do nothing if the subpage doesn't exist or is already stamped.

[Dan Beam, 2016/04/11 17:55:15]

don't we want to throw if we get to this code and it the routed page doesn't
exist?  it seems like this change might make it easier for programming errors to
happen, no?

[michaelpg, 2016/04/13 02:34:56]

I should clarify the comment. The subpage may be implemented as a
<neon-animatable> instead of a <template is="dom-if">, in which case we should
return early.

Obviously we don't do that anymore, but it's a valid state and something I run
into a lot when messing around locally trying to debug something. I don't think
this code should enforce that all subpages must be wrapped in <template>s.

+    if (!template || template.if)
       return;
 
     // Set the subpage's id for use by neon-animated-pages.