Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1878543002: Add a regression test for focus behavior with slots that are assigned to a slot (Closed)

Created:
4 years, 8 months ago by yuzuchan
Modified:
4 years, 8 months ago
Reviewers:
hayato, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a regression test for focus behavior with slots that are assigned to a slot This CL adds a regression layout test for focus behavior when there are slots that are assigned to a slot. BUG=599389 Committed: https://crrev.com/28c82331476120b4b7483ce9114ae6ae43a530f5 Cr-Commit-Position: refs/heads/master@{#386934}

Patch Set 1 #

Patch Set 2 : Update test description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
A + third_party/WebKit/LayoutTests/shadow-dom/slot-assigned-slot.html View 1 4 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yuzuchan
PTAL :) This is how I feel about this patch: http://i.imgur.com/KhGmjX1.gif
4 years, 8 months ago (2016-04-11 07:59:26 UTC) #2
kochi
lgtm
4 years, 8 months ago (2016-04-12 06:25:00 UTC) #3
hayato
lgtm
4 years, 8 months ago (2016-04-13 06:40:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878543002/20001
4 years, 8 months ago (2016-04-13 06:57:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 08:08:06 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 08:09:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28c82331476120b4b7483ce9114ae6ae43a530f5
Cr-Commit-Position: refs/heads/master@{#386934}

Powered by Google App Engine
This is Rietveld 408576698