Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
index 054dedc9554944ddb0b5c2b0ad508f0104737c78..7b0f6cd4d63e6f641fe9b0d5c20ab3099af20b11 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
@@ -51,11 +51,11 @@ SpellCheckRequest::SpellCheckRequest(
, m_requestData(unrequestedTextCheckingSequence, text, mask, processType, documentMarkersInRange, documentMarkerOffsets)
, m_requestNumber(requestNumber)
{
- ASSERT(m_checkingRange);
- ASSERT(m_checkingRange->inShadowIncludingDocument());
- ASSERT(m_paragraphRange);
- ASSERT(m_paragraphRange->inShadowIncludingDocument());
- ASSERT(m_rootEditableElement);
+ DCHECK(m_checkingRange);
+ DCHECK(m_checkingRange->inShadowIncludingDocument());
+ DCHECK(m_paragraphRange);
+ DCHECK(m_paragraphRange->inShadowIncludingDocument());
+ DCHECK(m_rootEditableElement);
}
SpellCheckRequest::~SpellCheckRequest()
@@ -140,8 +140,8 @@ void SpellCheckRequest::didCancel()
void SpellCheckRequest::setCheckerAndSequence(SpellCheckRequester* requester, int sequence)
{
- ASSERT(!m_requester);
- ASSERT(m_requestData.sequence() == unrequestedTextCheckingSequence);
+ DCHECK(!m_requester);
+ DCHECK_EQ(m_requestData.sequence(), unrequestedTextCheckingSequence);
m_requester = requester;
m_requestData.m_sequence = sequence;
}
@@ -178,7 +178,7 @@ TextCheckerClient& SpellCheckRequester::client() const
void SpellCheckRequester::timerFiredToProcessQueuedRequest(Timer<SpellCheckRequester>*)
{
- ASSERT(!m_requestQueue.isEmpty());
+ DCHECK(!m_requestQueue.isEmpty());
if (m_requestQueue.isEmpty())
return;
@@ -205,7 +205,7 @@ void SpellCheckRequester::requestCheckingFor(RawPtr<SpellCheckRequest> request)
if (!request || !canCheckAsynchronously(request->paragraphRange().get()))
return;
- ASSERT(request->data().sequence() == unrequestedTextCheckingSequence);
+ DCHECK_EQ(request->data().sequence(), unrequestedTextCheckingSequence);
int sequence = ++m_lastRequestSequence;
if (sequence == unrequestedTextCheckingSequence)
sequence = ++m_lastRequestSequence;
@@ -241,7 +241,7 @@ void SpellCheckRequester::prepareForLeakDetection()
void SpellCheckRequester::invokeRequest(RawPtr<SpellCheckRequest> request)
{
- ASSERT(!m_processingRequest);
+ DCHECK(!m_processingRequest);
m_processingRequest = request;
client().requestCheckingOfString(m_processingRequest);
}
@@ -257,7 +257,7 @@ void SpellCheckRequester::clearProcessingRequest()
void SpellCheckRequester::enqueueRequest(RawPtr<SpellCheckRequest> request)
{
- ASSERT(request);
+ DCHECK(request);
bool continuation = false;
if (!m_requestQueue.isEmpty()) {
RawPtr<SpellCheckRequest> lastRequest = m_requestQueue.last();
@@ -283,8 +283,8 @@ void SpellCheckRequester::enqueueRequest(RawPtr<SpellCheckRequest> request)
void SpellCheckRequester::didCheck(int sequence, const Vector<TextCheckingResult>& results)
{
- ASSERT(m_processingRequest);
- ASSERT(m_processingRequest->data().sequence() == sequence);
+ DCHECK(m_processingRequest);
+ DCHECK_EQ(m_processingRequest->data().sequence(), sequence);
if (m_processingRequest->data().sequence() != sequence) {
m_requestQueue.clear();
return;

Powered by Google App Engine
This is Rietveld 408576698