third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp - Issue 1878473002: ASSERT -> DCHECK in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp

Issue 1878473002: ASSERT -> DCHECK in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp b/third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp

index ad144a99816ade93dedc28ab3db7d0bfa77ebdcd..5947ea381f85ae55a9546edbd217609381e703b1 100644

--- a/third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp

@@ -54,7 +54,7 @@ static USet* getSmartSet(bool isPreviousCharacter)

UErrorCode ec = U_ZERO_ERROR;

String whitespaceAndNewline("[[:WSpace:] [\\u000A\\u000B\\u000C\\u000D\\u0085]]");

smartSet = uset_openPattern(whitespaceAndNewline.charactersWithNullTermination().data(), whitespaceAndNewline.length(), &ec);

- ASSERT(U_SUCCESS(ec));

+ DCHECK(U_SUCCESS(ec));

yosin_UTC9 2016/04/14 04:35:03 How about adding |<< ec|?

// CJK ranges

uset_addRange(smartSet, 0x1100, 0x1100 + 256); // Hangul Jamo (0x1100 - 0x11FF)

@@ -78,7 +78,7 @@ static USet* getSmartSet(bool isPreviousCharacter)

UErrorCode ec = U_ZERO_ERROR;

String punctuationClass("[:P:]");

USet* icuPunct = uset_openPattern(punctuationClass.charactersWithNullTermination().data(), punctuationClass.length(), &ec);

- ASSERT(U_SUCCESS(ec));

+ DCHECK(U_SUCCESS(ec));

yosin_UTC9 2016/04/14 04:35:03 How about adding |<< ec|?

uset_addAll(smartSet, icuPunct);

uset_close(icuPunct);