Chromium Code Reviews| Index: third_party/WebKit/Source/core/editing/Position.h |
| diff --git a/third_party/WebKit/Source/core/editing/Position.h b/third_party/WebKit/Source/core/editing/Position.h |
| index fb9843e8b455999074e5883a99cd5eed364f91d7..a29b93cd9c1a8e778ae7ea080bb71135c45122c7 100644 |
| --- a/third_party/WebKit/Source/core/editing/Position.h |
| +++ b/third_party/WebKit/Source/core/editing/Position.h |
| @@ -100,7 +100,7 @@ public: |
| // Inline O(1) access for Positions which callers know to be parent-anchored |
| int offsetInContainerNode() const |
| { |
| - ASSERT(isOffsetInAnchor()); |
| + DCHECK(isOffsetInAnchor()); |
| return m_offset; |
| } |
| @@ -232,10 +232,10 @@ bool operator!=(const PositionTemplate<Strategy>& a, const PositionTemplate<Stra |
| template <typename Strategy> |
| PositionTemplate<Strategy> PositionTemplate<Strategy>::inParentBeforeNode(const Node& node) |
| { |
| - // FIXME: This should ASSERT(node.parentNode()) |
| + // FIXME: This should DCHECK(node.parentNode()) |
| // At least one caller currently hits this ASSERT though, which indicates |
| // that the caller is trying to make a position relative to a disconnected node (which is likely an error) |
| - // Specifically, editing/deleting/delete-ligature-001.html crashes with ASSERT(node->parentNode()) |
| + // Specifically, editing/deleting/delete-ligature-001.html crashes with DCHECK(node->parentNode()) |
| return PositionTemplate<Strategy>(Strategy::parent(node), Strategy::index(node)); |
| } |
| @@ -247,7 +247,7 @@ inline Position positionInParentBeforeNode(const Node& node) |
| template <typename Strategy> |
| PositionTemplate<Strategy> PositionTemplate<Strategy>::inParentAfterNode(const Node& node) |
| { |
| - ASSERT(node.parentNode()); |
| + DCHECK(node.parentNode()); |
|
yosin_UTC9
2016/04/14 04:35:00
How about adding |<< node|?
|
| return PositionTemplate<Strategy>(Strategy::parent(node), Strategy::index(node) + 1); |
| } |
| @@ -260,7 +260,7 @@ inline Position positionInParentAfterNode(const Node& node) |
| template <typename Strategy> |
| PositionTemplate<Strategy> PositionTemplate<Strategy>::beforeNode(Node* anchorNode) |
| { |
| - ASSERT(anchorNode); |
| + DCHECK(anchorNode); |
| return PositionTemplate<Strategy>(anchorNode, PositionAnchorType::BeforeAnchor); |
| } |
| @@ -272,7 +272,7 @@ inline Position positionBeforeNode(Node* anchorNode) |
| template <typename Strategy> |
| PositionTemplate<Strategy> PositionTemplate<Strategy>::afterNode(Node* anchorNode) |
| { |
| - ASSERT(anchorNode); |
| + DCHECK(anchorNode); |
| return PositionTemplate<Strategy>(anchorNode, PositionAnchorType::AfterAnchor); |
| } |