third_party/WebKit/Source/web/WebArrayBufferConverter.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebArrayBufferConverter.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('K') | « third_party/WebKit/Source/web/WebArrayBuffer.cpp ('k') | third_party/WebKit/Source/web/WebArrayBufferView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebArrayBufferConverter.cpp

diff --git a/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp b/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp

index b25e409e0cd21cb5b01ac76f9e93524b28ade8c4..4235910392403a8c4cf1d1c6b0a0bf30af51e7ce 100644

--- a/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp

+++ b/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp

@@ -41,7 +41,7 @@ v8::Local<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer,

DCHECK(creationContext->CreationContext() == isolate->GetCurrentContext());

if (!buffer)

return v8::Local<v8::Value>();

- return toV8(PassRefPtr<DOMArrayBuffer>(*buffer), isolate->GetCurrentContext()->Global(), isolate);

+ return toV8(*buffer, isolate->GetCurrentContext()->Global(), isolate);

}

WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Local<v8::Value> value, v8::Isolate* isolate)