third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Unified Diff: third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('K') | « third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp ('k') | third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp b/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp

index b344c42b21b12208c9799b5bb102db13174dde46..ceb472591a0ce686892641c6bc0031291cb75d9b 100644

--- a/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp

+++ b/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp

@@ -598,7 +598,7 @@ TEST_F(DOMWebSocketTest, sendNonLatin1String)

TEST_F(DOMWebSocketTest, sendArrayBufferWhenConnecting)

{

- RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);

+ DOMArrayBufferView* view = DOMUint8Array::create(8);

{

InSequence s;

EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));

@@ -607,7 +607,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenConnecting)

EXPECT_FALSE(m_exceptionState.hadException());

- m_websocket->send(view->buffer().get(), m_exceptionState);

+ m_websocket->send(view->buffer(), m_exceptionState);

EXPECT_TRUE(m_exceptionState.hadException());

EXPECT_EQ(InvalidStateError, m_exceptionState.code());

@@ -617,7 +617,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenConnecting)

TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosing)

{

- RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);

+ DOMArrayBufferView* view = DOMUint8Array::create(8);

{

InSequence s;

EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));

@@ -630,7 +630,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosing)

m_websocket->close(m_exceptionState);

EXPECT_FALSE(m_exceptionState.hadException());

- m_websocket->send(view->buffer().get(), m_exceptionState);

+ m_websocket->send(view->buffer(), m_exceptionState);

EXPECT_FALSE(m_exceptionState.hadException());

EXPECT_EQ(DOMWebSocket::CLOSING, m_websocket->readyState());

@@ -639,7 +639,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosing)

TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosed)

{

Checkpoint checkpoint;

- RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);

+ DOMArrayBufferView* view = DOMUint8Array::create(8);

{

InSequence s;

EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));

@@ -653,7 +653,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosed)

m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");

checkpoint.Call(1);

- m_websocket->send(view->buffer().get(), m_exceptionState);

+ m_websocket->send(view->buffer(), m_exceptionState);

EXPECT_FALSE(m_exceptionState.hadException());

EXPECT_EQ(DOMWebSocket::CLOSED, m_websocket->readyState());

@@ -661,7 +661,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosed)

TEST_F(DOMWebSocketTest, sendArrayBufferSuccess)

{

- RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);

+ DOMArrayBufferView* view = DOMUint8Array::create(8);

{

InSequence s;

EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));

@@ -672,7 +672,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferSuccess)

EXPECT_FALSE(m_exceptionState.hadException());

m_websocket->didConnect("", "");

- m_websocket->send(view->buffer().get(), m_exceptionState);

+ m_websocket->send(view->buffer(), m_exceptionState);

EXPECT_FALSE(m_exceptionState.hadException());

EXPECT_EQ(DOMWebSocket::OPEN, m_websocket->readyState());