third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('K') | « third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.h ('k') | third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp b/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

index 5cad114545104c6d0209d88e7c3e82dbe5956412..1f21d1af9b37795fdd0917687643a220f0b1a16e 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

@@ -213,7 +213,7 @@ void MIDIOutput::send(Vector<unsigned> unsignedData, double timestamp, Exception

if (timestamp == 0.0)

timestamp = now(getExecutionContext());

- RefPtr<DOMUint8Array> array = DOMUint8Array::create(unsignedData.size());

+ DOMUint8Array* array = DOMUint8Array::create(unsignedData.size());

DOMUint8Array::ValueType* const arrayData = array->data();

const uint32_t arrayLength = array->length();

@@ -226,7 +226,7 @@ void MIDIOutput::send(Vector<unsigned> unsignedData, double timestamp, Exception

arrayData[i] = unsignedData[i] & 0xff;

}

- send(array.get(), timestamp, exceptionState);

+ send(array, timestamp, exceptionState);

}

void MIDIOutput::send(DOMUint8Array* data, ExceptionState& exceptionState)