third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('K') | « third_party/WebKit/Source/modules/push_messaging/PushSubscription.h ('k') | third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

index 01fda88de8800b7e1f85c7aa94ae76aea19418e0..b50912b0b40ab33e965f9bda5fd0677e48aa0fe2 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

@@ -48,7 +48,7 @@ KURL PushSubscription::endpoint() const

return m_endpoint;

}

-PassRefPtr<DOMArrayBuffer> PushSubscription::getKey(const AtomicString& name) const

+DOMArrayBuffer* PushSubscription::getKey(const AtomicString& name) const

{

if (name == "p256dh")

return m_p256dh;

@@ -90,6 +90,8 @@ ScriptValue PushSubscription::toJSONForBinding(ScriptState* scriptState)

DEFINE_TRACE(PushSubscription)

{

+ visitor->trace(m_p256dh);

+ visitor->trace(m_auth);

visitor->trace(m_serviceWorkerRegistration);

}