third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('K') | « third_party/WebKit/Source/modules/push_messaging/PushMessageData.h ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscription.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

index a7b133d9d2d7bbe82f776b135dd5b8fcb9ecc598..b6c96284163fc2185564c492198e97820d94b8c5 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

@@ -29,7 +29,7 @@ PushMessageData* PushMessageData::create(const String& messageString)

PushMessageData* PushMessageData::create(const ArrayBufferOrArrayBufferViewOrUSVString& messageData)

{

if (messageData.isArrayBuffer() || messageData.isArrayBufferView()) {

- RefPtr<DOMArrayBuffer> buffer = messageData.isArrayBufferView()

+ DOMArrayBuffer* buffer = messageData.isArrayBufferView()

? messageData.getAsArrayBufferView()->buffer()

: messageData.getAsArrayBuffer();

@@ -54,7 +54,7 @@ PushMessageData::~PushMessageData()

{

}

-PassRefPtr<DOMArrayBuffer> PushMessageData::arrayBuffer() const

+DOMArrayBuffer* PushMessageData::arrayBuffer() const

{

return DOMArrayBuffer::create(m_data.data(), m_data.size());

}