third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('K') | « third_party/WebKit/Source/modules/mediasource/SourceBuffer.h ('k') | third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

index 9edf22ea2786855e941702d4f7e8e5bc65cd06a7..9914b7d188f507ecf5cf63c6297c348365bfd667 100644

--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

@@ -313,7 +313,7 @@ void SourceBuffer::setAppendWindowEnd(double end, ExceptionState& exceptionState

m_appendWindowEnd = end;

}

-void SourceBuffer::appendBuffer(PassRefPtr<DOMArrayBuffer> data, ExceptionState& exceptionState)

+void SourceBuffer::appendBuffer(DOMArrayBuffer* data, ExceptionState& exceptionState)

{

WTF_LOG(Media, "SourceBuffer(%p)::appendBuffer size=%u", this, data->byteLength());

// Section 3.2 appendBuffer()

@@ -321,7 +321,7 @@ void SourceBuffer::appendBuffer(PassRefPtr<DOMArrayBuffer> data, ExceptionState&

appendBufferInternal(static_cast<const unsigned char*>(data->data()), data->byteLength(), exceptionState);

}

-void SourceBuffer::appendBuffer(PassRefPtr<DOMArrayBufferView> data, ExceptionState& exceptionState)

+void SourceBuffer::appendBuffer(DOMArrayBufferView* data, ExceptionState& exceptionState)

{

WTF_LOG(Media, "SourceBuffer(%p)::appendBuffer size=%u", this, data->byteLength());

// Section 3.2 appendBuffer()