third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('K') | « third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp ('k') | third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

index cfad31f7a9b99dffdc7b4046aaec54291255fadc..a55257e1df9981e92d3fa3f7a31528fab4fc2533 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

@@ -161,7 +161,7 @@ TEST_F(FetchFormDataConsumerHandleTest, ReadFromStringNonLatin)

TEST_F(FetchFormDataConsumerHandleTest, ReadFromArrayBuffer)

{

const unsigned char data[] = { 0x21, 0xfe, 0x00, 0x00, 0xff, 0xa3, 0x42, 0x30, 0x42, 0x99, 0x88 };

- RefPtr<DOMArrayBuffer> buffer = DOMArrayBuffer::create(data, WTF_ARRAY_LENGTH(data));

+ DOMArrayBuffer* buffer = DOMArrayBuffer::create(data, WTF_ARRAY_LENGTH(data));

OwnPtr<FetchDataConsumerHandle> handle = FetchFormDataConsumerHandle::create(buffer);

HandleReaderRunner<HandleReader> runner(handle.release());

OwnPtr<HandleReadResult> r = runner.wait();

@@ -175,7 +175,7 @@ TEST_F(FetchFormDataConsumerHandleTest, ReadFromArrayBufferView)

{

const unsigned char data[] = { 0x21, 0xfe, 0x00, 0x00, 0xff, 0xa3, 0x42, 0x30, 0x42, 0x99, 0x88 };

const size_t offset = 1, size = 4;

- RefPtr<DOMArrayBuffer> buffer = DOMArrayBuffer::create(data, WTF_ARRAY_LENGTH(data));

+ DOMArrayBuffer* buffer = DOMArrayBuffer::create(data, WTF_ARRAY_LENGTH(data));

OwnPtr<FetchDataConsumerHandle> handle = FetchFormDataConsumerHandle::create(DOMUint8Array::create(buffer, offset, size));

HandleReaderRunner<HandleReader> runner(handle.release());

OwnPtr<HandleReadResult> r = runner.wait();