Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tidy Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
index 70bb9fc46b0071623649f5ee95b8e390da6f166c..98b21d664fb374ad336ecf7d56ad30d1277ceb41 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
@@ -49,7 +49,7 @@ public:
static BluetoothRemoteGATTCharacteristic* take(ScriptPromiseResolver*, PassOwnPtr<WebBluetoothRemoteGATTCharacteristicInit>);
// Save value.
- void setValue(const PassRefPtr<DOMDataView>&);
+ void setValue(DOMDataView*);
// WebBluetoothRemoteGATTCharacteristic interface:
void dispatchCharacteristicValueChanged(const WebVector<uint8_t>&) override;
@@ -76,7 +76,7 @@ public:
String uuid() { return m_webCharacteristic->uuid; }
BluetoothCharacteristicProperties* properties() { return m_properties; }
- PassRefPtr<DOMDataView> value() const { return m_value; }
+ DOMDataView* value() const { return m_value; }
ScriptPromise readValue(ScriptState*);
ScriptPromise writeValue(ScriptState*, const DOMArrayPiece&);
ScriptPromise startNotifications(ScriptState*);
@@ -92,7 +92,7 @@ private:
OwnPtr<WebBluetoothRemoteGATTCharacteristicInit> m_webCharacteristic;
bool m_stopped;
Member<BluetoothCharacteristicProperties> m_properties;
- RefPtr<DOMDataView> m_value;
+ Member<DOMDataView> m_value;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698