third_party/WebKit/Source/core/layout/shapes/Shape.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/shapes/Shape.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp ('K') | « third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp ('k') | third_party/WebKit/Source/core/loader/BeaconLoader.h » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/shapes/Shape.cpp

diff --git a/third_party/WebKit/Source/core/layout/shapes/Shape.cpp b/third_party/WebKit/Source/core/layout/shapes/Shape.cpp

index bd49b75582d01a38c0640f8c9ab75c8a11fb4979..8407f1eed075f6be5c69c11975f33fa3c6b69dd0 100644

--- a/third_party/WebKit/Source/core/layout/shapes/Shape.cpp

+++ b/third_party/WebKit/Source/core/layout/shapes/Shape.cpp

@@ -208,8 +208,8 @@ PassOwnPtr<Shape> Shape::createRasterShape(Image* image, float threshold, const

WTF::ArrayBufferContents contents;

imageBuffer->getImageData(Unmultiplied, IntRect(IntPoint(), imageRect.size()), contents);

- RefPtr<DOMArrayBuffer> arrayBuffer = DOMArrayBuffer::create(contents);

- RefPtr<DOMUint8ClampedArray> pixelArray = DOMUint8ClampedArray::create(arrayBuffer, 0, arrayBuffer->byteLength());

+ DOMArrayBuffer* arrayBuffer = DOMArrayBuffer::create(contents);

+ DOMUint8ClampedArray* pixelArray = DOMUint8ClampedArray::create(arrayBuffer, 0, arrayBuffer->byteLength());

unsigned pixelArrayOffset = 3; // Each pixel is four bytes: RGBA.

uint8_t alphaPixelThreshold = threshold * 255;